Fix ComponentTool deserialization in Responses generators - #12486
Closed
mikemikimike wants to merge 1 commit into
Closed
Fix ComponentTool deserialization in Responses generators#12486mikemikimike wants to merge 1 commit into
mikemikimike wants to merge 1 commit into
Conversation
|
@mikemikimike is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
|
Contributor
|
Closing as duplicate of #12485 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenAIResponsesChatGeneratorandAzureOpenAIResponsesChatGeneratoronly recognized serializedToolandToolsettype names when deserializing. SerializedComponentToolinstances were therefore left as dictionaries.This change identifies serialized Haystack tools by their data payload, preserving the existing handling for OpenAI-native tools while restoring
ComponentToolinstances for both Responses generators.Tests
uv run pytest test/components/generators/chat/test_openai_responses.py::TestSerDe::test_from_dict_with_component_tool test/components/generators/chat/test_azure_responses.py::TestSerDe::test_from_dict_with_component_toolRuff validation is currently blocked by the repository's existing unsupported
RUF104rule configuration.