fix(async/unstable): count circuit breaker requests at completion - #7307
Open
tomas-zijdemans wants to merge 1 commit into
Open
fix(async/unstable): count circuit breaker requests at completion#7307tomas-zijdemans wants to merge 1 commit into
tomas-zijdemans wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7307 +/- ##
=======================================
Coverage 95.03% 95.03%
=======================================
Files 617 617
Lines 51637 51641 +4
Branches 9359 9359
=======================================
+ Hits 49075 49079 +4
Misses 2021 2021
Partials 541 541 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The circuit breaker counted a request when it was admitted but counted its failure when it completed, and the failure path never rotated the sliding window. Two things went wrong across an
await:Requests are now counted on completion, right after rotating, so a request and its outcome always land in the same segment. Callbacks still report the same totals for requests that complete in order.
Two tests cover the mismatch and the stale history. Both fail on main.