Skip to content

Add Microsoft's speech-sdk-spm to egress allowlist #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomotakatakahashi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Microsoft's speech-sdk-spm to egress allowlist #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/handlers/egress_allowlist_defaults.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,5 +684,10 @@ ecosystem_default_domains:
# (RealSprint/vindral-apple-sdk-spm). Anonymous, no redirect.
# Exact: *.vindral.com also fronts the vendor's CDN and stage/test hosts.
- applesdk.vindral.com
# Microsoft's Speech SDK storage account, serving the
# MicrosoftCognitiveServicesSpeech XCFramework zip binaryTargets declared in
# the vendor's own public Package.swift (microsoft/speech-sdk-spm).
# Anonymous, no redirect.
- csspeechstorage.blob.core.windows.net
vcpkg: []
pre_commit: []
9 changes: 9 additions & 0 deletions internal/handlers/egress_allowlist_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,6 +760,7 @@ func TestEgressAllowlist_NewEntriesDoNotWidenBeyondExactHosts(t *testing.T) {
"https://evil.wiz-sec.github.io/payload",
"https://evil.fluent.github.io/payload",
"https://evil.adsbynimbus-public.s3.amazonaws.com/payload",
"https://evil.csspeechstorage.blob.core.windows.net/payload",
}

// Sibling hosts: names sharing a parent with an added entry. These pin the
Expand Down Expand Up @@ -1282,6 +1283,9 @@ func TestEgressAllowlist_PublicVendorRegistriesAllowed(t *testing.T) {
"https://sf16-fe-tos-sg.i18n-pglstatp.com/obj/pangle-sdk-static-va/8.3.0.8/TikTokBusinessSDK.xcframework.zip",
// Same failure mode for the Vindral Apple SDK's VindralStreaming binaryTarget.
"https://applesdk.vindral.com/tag/1.2.0/VindralStreaming.zip",
// Same failure mode for the Microsoft Speech SDK's XCFramework binaryTargets.
"https://csspeechstorage.blob.core.windows.net/drop/1.53.0/MicrosoftCognitiveServicesSpeech-XCFramework-1.53.0.zip",
"https://csspeechstorage.blob.core.windows.net/drop/1.53.0/MicrosoftCognitiveServicesSpeech-MacOSXCFramework-1.53.0.zip",
} {
assert.Nil(t, egressResult(t, h, allowed), "public vendor registry allowed: "+allowed)
}
Expand Down Expand Up @@ -1333,6 +1337,11 @@ func TestEgressAllowlist_PublicVendorRegistriesAllowed(t *testing.T) {
"https://evil.applesdk.vindral.com/payload",
"https://attacker.vindral.com/payload",
"https://vindral.com/payload",
// The Speech SDK storage account is one exact host: no children, no
// lookalike accounts, and never other accounts on blob.core.windows.net.
"https://evil.csspeechstorage.blob.core.windows.net/payload",
"https://csspeechstorageattacker.blob.core.windows.net/payload",
"https://attacker.blob.core.windows.net/payload",
} {
resp := egressResult(t, h, blocked)
if assert.NotNil(t, resp, "must stay blocked: "+blocked) {
Expand Down
Loading