chore: drop duplicate vocabulary entries and lint for them - #566
Merged
Merged
Conversation
Twelve set literals in nameparser/config held an entry twice (eleven in SUFFIX_ACRONYMS, 'marquis' in TITLES). A frozenset keeps one copy, so no set changed; every frozenset in both modules compares equal to master's. Enabling ruff's B033 keeps the next bulk import from bringing duplicates back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #566 +/- ##
=======================================
Coverage 98.85% 98.86%
=======================================
Files 45 45
Lines 3935 3959 +24
=======================================
+ Hits 3890 3914 +24
Misses 45 45 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twelve set literals in
nameparser/configheld an entry twice:SUFFIX_ACRONYMS:ae,afc,afm,cgm,chfc,gcb,gcmg,gcvo,kcie,kcsi,vcTITLES:marquisA frozenset keeps one copy, so no behavior changes. Verified by executing master's
suffixes.pyandtitles.pyand comparing every module-level frozenset against the branch's: all identical.Also enables ruff's
B033(duplicate set items) inextend-select, so the next bulk vocabulary import can't bring duplicates back.uv run ruff checkpasses.No release-log entry: there is no user-visible change.
🤖 Generated with Claude Code