Skip to content

fix(ci): preserve existing assets when retrying releases #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
owjs3901 merged 2 commits into from
Oct 1, 2026
Merged

fix(ci): preserve existing assets when retrying releases #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecf155c
fix(ci): skip existing release assets on publication retry
owjs3901 Oct 1, 2026
ee87dfd
fix(ci): skip only completed nonempty release assets
owjs3901 Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/scripts/upload-release-assets.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
#!/usr/bin/env bash
set -euo pipefail

upload_url="$1"
shift
release_id="${upload_url#*/releases/}"
release_id="${release_id%%/*}"
[[ "$release_id" =~ ^[0-9]+$ ]] || { echo "Invalid release upload URL" >&2; exit 1; }

release_tag=$(gh api "repos/$GITHUB_REPOSITORY/releases/$release_id" --jq .tag_name)
# Failed uploads can retain a name in the starter state. Only completed,
# nonempty binary/wheel assets may be skipped; collisions otherwise fail safely.
existing_assets=$(gh api "repos/$GITHUB_REPOSITORY/releases/$release_id/assets" --paginate --jq '.[] | select(.state == "uploaded" and .size > 0) | .name')

for asset in "$@"; do
[[ -f "$asset" ]] || { echo "Missing release asset: $asset" >&2; exit 1; }
asset_name=$(basename -- "$asset")
if grep -Fxq -- "$asset_name" <<< "$existing_assets"; then
echo "::notice::$asset_name is already uploaded; skipping."
continue
fi
gh release upload "$release_tag" "$asset" --repo "$GITHUB_REPOSITORY"
done
17 changes: 9 additions & 8 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,10 +362,10 @@ jobs:
publish_package "$RUNNER_TEMP/npm-publish/cli/"*.tgz
working-directory: bridge/node
- name: Upload Asset
uses: owjs3901/upload-github-release-asset@main
with:
upload_url: ${{ fromJson(needs.changepacks.outputs.release_assets_urls)['bridge/node/package.json'] }}
asset_path: bridge/node/npm/*/dependency-check-updates.*.node
env:
GH_TOKEN: ${{ github.token }}
RELEASE_UPLOAD_URL: ${{ fromJson(needs.changepacks.outputs.release_assets_urls)['bridge/node/package.json'] }}
run: bash .github/scripts/upload-release-assets.sh "$RELEASE_UPLOAD_URL" bridge/node/npm/*/dependency-check-updates.*.node

python-publish:
name: Python Publish
Expand All @@ -379,6 +379,7 @@ jobs:
contents: write
attestations: write
steps:
- uses: actions/checkout@v7
- uses: actions/download-artifact@v8
- name: Generate artifact attestation
uses: actions/attest-build-provenance@v4
Expand All @@ -394,10 +395,10 @@ jobs:
- name: List wheels
run: ls -R .
- name: Upload Asset
uses: owjs3901/upload-github-release-asset@main
with:
upload_url: ${{ fromJson(needs.changepacks.outputs.release_assets_urls)['bridge/python/pyproject.toml'] }}
asset_path: "*/*.whl"
env:
GH_TOKEN: ${{ github.token }}
RELEASE_UPLOAD_URL: ${{ fromJson(needs.changepacks.outputs.release_assets_urls)['bridge/python/pyproject.toml'] }}
run: bash .github/scripts/upload-release-assets.sh "$RELEASE_UPLOAD_URL" wheels-*/*.whl

finalize-releases:
name: Finalize published releases
Expand Down
Loading