Conversation
Refs #692 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
…ore test order Refs #692 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Contributor
Changepacks@devup-ui/wasm@1.0.82 → 1.0.83 - bindings/devup-ui-wasm/package.jsonPatch
@devup-ui/bun-plugin@1.0.21 → 1.0.22 - packages/bun-plugin/package.jsonPatch
@devup-ui/components@0.1.59 → 0.1.60 - packages/components/package.jsonPatch
@devup-ui/eslint-plugin@1.0.21 → 1.0.22 - packages/eslint-plugin/package.jsonPatch
@devup-ui/next-plugin@1.0.89 → 1.0.90 - packages/next-plugin/package.jsonPatch
@devup-ui/plugin-utils@1.0.16 → 1.0.17 - packages/plugin-utils/package.jsonPatch
@devup-ui/rsbuild-plugin@1.0.66 → 1.0.67 - packages/rsbuild-plugin/package.jsonPatch
@devup-ui/vite-plugin@1.0.72 → 1.0.73 - packages/vite-plugin/package.jsonPatch
@devup-ui/webpack-plugin@1.0.70 → 1.0.71 - packages/webpack-plugin/package.jsonPatch
|
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #692 (I 세 번째 PR).
main에서 분기했습니다.문제
aria-expanded/aria-label만 있었고, 팝업과 옵션은 일반 div였습니다. role,aria-controls, 키보드 이동, Escape, 포커스 복귀가 없었습니다.onOpenChange를 거치지 않고 내부 상태만 바꿔,open을 제어하는 쪽은 닫힘을 알 수 없었습니다.변경
aria-haspopup="listbox",aria-controls를 붙이고, 닫힌 상태에서 ArrowDown/ArrowUp으로 엽니다.asChild트리거도 같습니다.role="listbox", id를 붙이고 checkbox 타입이면aria-multiselectable을 붙입니다.role="option",aria-selected,aria-disabled,tabIndex=-1을 붙입니다.onOpenChange(false)를 호출하고, 제어되지 않을 때만 내부 상태를 바꿉니다.동작 변화
openprop)에서는 바깥 클릭이 더 이상 숨은 상태를 바꾸지 않고 소유자에게 알립니다.새로 생기는 오류
검증
bun test5478개 통과, 커버리지 100%. 새 테스트는 키보드 조작, asChild/checkbox, 제어·비제어 바깥 클릭입니다.bun lint오류 0개, components 빌드 통과.useId의존을 없애려고 테스트의 Select에id를 고정했습니다(중첩 Select는 별도 id).useId를 쓰면서 CI의 테스트 순서에서 Checkbox 스냅샷 id가 밀려, #723과 같은 Checkbox 수정(주어진id사용, 테스트 id 고정)을 그대로 넣었습니다. 두 PR의 해당 변경은 같은 내용이라 충돌 없이 병합됩니다.assert_is_empty수정은 fix(extractor): let a later css() part replace an earlier one's declarations #706 등과 같은 내용입니다.