Adding OhMyZsh-Theme Option to common-utils feature - #1564
Open
Daniel Glaser (the78mole) wants to merge 19 commits into
Open
Daniel Glaser (the78mole) wants to merge 19 commits into
Daniel Glaser (the78mole) wants to merge 19 commits into
Conversation
Co-authored-by: the78mole <7723396+the78mole@users.noreply.github.com>
Co-authored-by: the78mole <7723396+the78mole@users.noreply.github.com>
Co-authored-by: the78mole <7723396+the78mole@users.noreply.github.com>
Add ohMyZshTheme configuration option to common-utils
Author
|
@microsoft-github-policy-service agree |
Kaniska (v-Kaniska244)
requested changes
Feb 10, 2026
Kaniska (v-Kaniska244)
left a comment
Kaniska (v-Kaniska244)
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the contribution. Would you kindly do a minor common-utils feature version bump for this.
Author
|
Totally forgot that... For sure I can bump the version... |
Author
|
Sorry, some commits on my main have not been intended... I'll removing it again... (in a few minutes) |
Daniel Glaser (the78mole)
force-pushed
the
main
branch
from
June 10, 2026 12:30
b37565c to
719bdab
Compare
Resolves three conflicts in common-utils, all of the same shape: upstream added the `sudoers` option (devcontainers#1723) right where this fork adds `addGroups`. Both sides kept — the options are independent and each is fully wired up (declaration plus use in main.sh).
The FUNDING.yml was added to this fork by accident and never belonged in PR devcontainers#1564. It was malformed anyway — the first line held two U+FFFD replacement characters left over from an unexpanded shell variable. Upstream carries no FUNDING.yml, so the file is simply removed. Bump common-utils 2.6.0 -> 2.7.0: upstream released `sudoers` as 2.6.0, while this fork's 2.6.0 already carried `ohMyZshTheme` and `addGroups`. After the merge the same version number would describe two different option sets, so the merged feature needs its own version.
Kaniska (v-Kaniska244)
left a comment
Kaniska (v-Kaniska244)
left a comment
Contributor
There was a problem hiding this comment.
LGTM except one small change required in test. Kindly correct the same.
The add-groups scenario pinned debian:bullseye. Debian 11 is end-of-life and its security pool is no longer served, so the scenario now fails while installing sudo/git/gnupg2: E: Failed to fetch http://deb.debian.org/debian-security/pool/updates/ main/s/sudo/sudo_1.9.5p2-3+deb11u4_amd64.deb Upstream removed debian:11 from the CI matrices for this reason (devcontainers#1736); this was the last reference left in the repository. Switched to debian:trixie, already the most used Debian image in this scenario file. Nothing in add-groups.sh is release-specific. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Follow-up to the previous commit, which moved the scenario off EOL debian:bullseye to debian:trixie. A maintainer asked for bookworm (12) in review, so use that instead: devcontainers#1564 (review comment on scenarios.json:139) Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for customizing the Oh My Zsh theme during installation in the
common-utilsfeature. The main changes include introducing a newohMyZshThemeoption, updating scripts to handle this option safely, and adding tests to verify theme customization.Feature: Oh My Zsh Theme Customization
ohMyZshThemeoption todevcontainer-feature.json, allowing users to specify the Oh My Zsh theme (default:devcontainers).README.mdto document the newohMyZshThemeoption and its usage.Feature: Add groups to non-root User
addGroupsoption todevcontainer-feature.json, allowing users to specify additional groups the non-root user shall belong to.README.mdto document the newaddGroupsoption and its usage.Implementation: Script Updates
install.shandmain.shto accept and use theOH_MY_ZSH_THEMEenvironment variable, defaulting todevcontainersif not specified. [1] [2]install.shandmain.shto accept and use the newADD_GROUPSenvironment variable, defaulting to no value if not specified.main.shto validate the theme name and update.zshrcaccordingly, falling back to the default if the provided name is invalid.main.shto validate the groups, creating them if not existent.Testing: Custom Theme Scenario
custom-zsh-theme.shto verify that the specified theme is applied and Oh My Zsh is installed.scenarios.jsonto include a scenario for testing custom theme installation with thefinotheme.scenarios.jsonto include a scenario for testing adding groups plugdev and dialout (usually needed for embedded development.