Update webhook RBAC and client - #1703
Conversation
The webhook server's httpfactory reads TLS certificate ConfigMaps through the cached client, which requires watch permission to set up an informer. Without it the informer never syncs and admission requests time out with EOF. Assisted-by: Claude Code Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: David Kwon <dakwon@redhat.com>
The webhook's resolveDevWorkspace used the manager's cached client to fetch DevWorkspaceTemplates, which created informers that cached all DWTs in memory. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: David Kwon <dakwon@redhat.com>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dkwon17 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What does this PR do?
What issues does this PR fix or reference?
Is it tested? How?
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che