Skip to content

Update webhook RBAC and client - #1703

Draft
dkwon17 wants to merge 2 commits into
devfile:mainfrom
dkwon17:configmap-rbac
Draft

Update webhook RBAC and client#1703
dkwon17 wants to merge 2 commits into
devfile:mainfrom
dkwon17:configmap-rbac

Conversation

@dkwon17

@dkwon17 dkwon17 commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

What issues does this PR fix or reference?

Is it tested? How?

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

dkwon17 and others added 2 commits September 9, 2026 16:24
The webhook server's httpfactory reads TLS certificate ConfigMaps through
the cached client, which requires watch permission to set up an informer.
Without it the informer never syncs and admission requests time out with EOF.

Assisted-by: Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: David Kwon <dakwon@redhat.com>
The webhook's resolveDevWorkspace used the manager's cached client to
fetch DevWorkspaceTemplates, which created informers that cached all
DWTs in memory.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: David Kwon <dakwon@redhat.com>
@openshift-ci

openshift-ci Bot commented Sep 9, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci

openshift-ci Bot commented Sep 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkwon17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Sep 9, 2026
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant