You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
msb create became boot-only upstream (superradcompany/microsandbox#1298, unreleased): the configured entrypoint no longer executes, so msb inspect reports the sandbox as running while the Devsy agent never starts.
Fix
Switch Create to msb run --detach. Instead of joining Entrypoint+Cmd into a single string and re-detecting shell-script shapes at the CLI boundary (the approach in #1036 — fragile: any argv shape the CLI's --entrypoint string can't represent gets silently dropped, running the image default instead), carry Entrypoint (string) and Cmd ([]string) separately on sandboxSpec, mirroring the split driver.RunOptions and the docker driver already use.
--entrypoint sets the executable; a trailing -- plus argv overrides the image CMD while preserving that entrypoint — this matches microsandbox's own OCI ENTRYPOINT/CMD resolution exactly, with no upstream fix required (see superradcompany/microsandbox#1340).
Fixes#1035. Supersedes #1036 (closing with credit to the original reporter/diagnosis).
Testing
go test ./pkg/driver/microsandbox/... — all pass, new cases cover: full spec, minimal spec, cmd-without-entrypoint, entrypoint-without-cmd.
golangci-lint run ./pkg/driver/microsandbox/... — 0 issues.
go build ./..., go vet (incl. microsandbox_integration build tag) — clean.
Summary by CodeRabbit
New Features
Improved sandbox startup with support for separate entrypoints and command overrides.
Added handling for sandbox names, images, runtime and resource settings, mounts, and optional egress restrictions.
Supports starting sandboxes in detached mode.
Bug Fixes
Ensures entrypoints and commands are passed independently, improving command execution behavior.
msb create became boot-only upstream (superradcompany/microsandbox#1298,
unreleased), so the microsandbox driver's entrypoint never executed and
the Devsy agent never started, even though msb inspect reported the
sandbox as running.
Switch Create to `msb run --detach`. Instead of joining Entrypoint+Cmd
into one string and re-detecting shell-script shapes (fragile: any
argv shape microsandbox's CLI --entrypoint can't represent would be
silently dropped, running the image default instead), carry
Entrypoint (string) and Cmd ([]string) separately on sandboxSpec, the
same split driver.RunOptions and the docker driver already use.
--entrypoint sets the executable; a trailing "--" plus argv overrides
the image CMD while preserving that entrypoint, matching
microsandbox's own OCI ENTRYPOINT/CMD resolution exactly.
Fixes#1035
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 474f8cc9-894f-443c-bff9-ee2c3cd38e62
📥 Commits
Reviewing files that changed from the base of the PR and between 7f67331 and e604519.
📒 Files selected for processing (5)
pkg/driver/microsandbox/cliclient.go
pkg/driver/microsandbox/cliclient_test.go
pkg/driver/microsandbox/client.go
pkg/driver/microsandbox/microsandbox.go
pkg/driver/microsandbox/microsandbox_test.go
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Walkthrough
Walkthrough
The Microsandbox driver now stores entrypoints and commands separately. Create starts sandboxes with msb run --detach, including runtime options, resources, mounts, images, and optional commands.
Changes
Microsandbox run flow
Layer / File(s)
Summary
Separate entrypoint and command specification pkg/driver/microsandbox/client.go, pkg/driver/microsandbox/microsandbox.go, pkg/driver/microsandbox/microsandbox_test.go
sandboxSpec now stores Entrypoint and Cmd separately. buildSpec preserves both fields, and tests validate the separate values.
Detached run argument construction pkg/driver/microsandbox/cliclient.go, pkg/driver/microsandbox/cliclient_test.go
Create now invokes msb run --detach. runArgs handles sandbox options, entrypoints, images, commands, resources, mounts, and egress denial. Tests cover full, minimal, command-only, and entrypoint-only cases.
The change updates microsandbox command invocation and preserves separate entrypoint and command arguments; no actionable merge-blocking risk remains after normal checks and review.
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
msb createbecame boot-only upstream (superradcompany/microsandbox#1298, unreleased): the configured entrypoint no longer executes, somsb inspectreports the sandbox asrunningwhile the Devsy agent never starts.Fix
Switch
Createtomsb run --detach. Instead of joiningEntrypoint+Cmdinto a single string and re-detecting shell-script shapes at the CLI boundary (the approach in #1036 — fragile: any argv shape the CLI's--entrypointstring can't represent gets silently dropped, running the image default instead), carryEntrypoint(string) andCmd([]string) separately onsandboxSpec, mirroring the splitdriver.RunOptionsand the docker driver already use.--entrypointsets the executable; a trailing--plus argv overrides the image CMD while preserving that entrypoint — this matches microsandbox's own OCI ENTRYPOINT/CMD resolution exactly, with no upstream fix required (see superradcompany/microsandbox#1340).Fixes #1035. Supersedes #1036 (closing with credit to the original reporter/diagnosis).
Testing
go test ./pkg/driver/microsandbox/...— all pass, new cases cover: full spec, minimal spec, cmd-without-entrypoint, entrypoint-without-cmd.golangci-lint run ./pkg/driver/microsandbox/...— 0 issues.go build ./...,go vet(incl.microsandbox_integrationbuild tag) — clean.Summary by CodeRabbit
New Features
Bug Fixes