Skip to content

skills(running-tend): settle the draft state of the tend workflow-regen PR #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dormouse-bot wants to merge 1 commit into from
+6 −0
Closed

skills(running-tend): settle the draft state of the tend workflow-regen PR #752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .claude/skills/running-tend/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,9 @@ Proposed as an overlay note and rejected in [#421](https://github.com/diffplug/d
Before a `review-runs`/`review-reviewers` sweep flags a tend behavior as waste or files it upstream, check this list — these were already raised and ruled on, so re-filing burns a session and spams upstream:

- **`tend-review` silently running a full review on the bot's own PRs is intended, not waste.** The diff read *is* the review — it catches lint failures and edge cases even though self-approval is impossible, so a silent exit means the review ran and found nothing to post. Ruled intended behavior by the upstream owner in [max-sixty/tend#607](https://github.com/max-sixty/tend/issues/607) (closed as intended, same ruling as tend#212/#154). Do not treat self-review-of-bot-PRs no-ops as cost waste and do not re-file. (The companion `tend-mention` no-op on undirected bot comments, [tend#606](https://github.com/max-sixty/tend/issues/606), was *fixed* upstream — that one is resolved, not rejected.)

## The tend workflow-regen PR stays non-draft

`tend-nightly` opens the `chore: update tend workflows (X → Y)` PR non-draft; leave it that way. `AGENTS.md`'s draft rule exists to control Chromatic spend, and Chromatic's `pull_request` paths (`lib/**`, `docs/stories/**`) never match a workflows-only diff, so neither `UI Tests` nor `Storybook Publish` runs on it either way. Converting it costs something real: the maintainer's later ready-flip routes through the verdict-drop path in [#665](https://github.com/diffplug/dormouse/issues/665).

@dormouse-bot dormouse-bot Sep 22, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the one section here without a decision behind it. Naming it as the bot's own reading keeps a future session from treating it as settled policy over AGENTS.md, and gives nedtwigg a single sentence to strike once they answer:

Suggested change
`tend-nightly` opens the `chore: update tend workflows (X → Y)` PR non-draft; leave it that way. `AGENTS.md`'s draft rule exists to control Chromatic spend, and Chromatic's `pull_request` paths (`lib/**`, `docs/stories/**`) never match a workflows-only diff, so neither `UI Tests` nor `Storybook Publish` runs on it either way. Converting it costs something real: the maintainer's later ready-flip routes through the verdict-drop path in [#665](https://github.com/diffplug/dormouse/issues/665).
`tend-nightly` opens the `chore: update tend workflows (X → Y)` PR non-draft; leave it that way. `AGENTS.md`'s draft rule exists to control Chromatic spend, and Chromatic's `pull_request` paths (`lib/**`, `docs/stories/**`) never match a workflows-only diff, so neither `UI Tests` nor `Storybook Publish` runs on it either way. Converting it costs something real: the maintainer's later ready-flip routes through the verdict-drop path in [#665](https://github.com/diffplug/dormouse/issues/665). Unlike the rulings above, this is the bot's own reading rather than a maintainer decision — proposed in [#752](https://github.com/diffplug/dormouse/pull/752); nedtwigg overrides it by saying so.


Don't re-derive this from the earlier workflow-regen PRs. `isDraft` reads `false` on every merged PR whatever it was opened as, so `gh pr list --state all --json isDraft` cannot answer how one was opened — only `issues/<n>/timeline`'s `convert_to_draft` and `ready_for_review` events can.
Loading