Share kysely, hono, stripe and pgstencil with applications as peers - #8
Merged
Merged
Conversation
Applications that import kysely themselves got a second copy whenever Renovate bumped theirs, because each pgstencil package pinned its own. Kysely classes have private fields, so the two copies are incompatible types (type-the-rhythm#355). Libraries whose objects cross the package boundary, or that hold module-level state, are now peers that the application owns. Better Auth and the other internal libraries stay private, with ranges instead of exact pins. packages:verify now declares each peer at the tested version and fails on unmet peers. Renovate widens peers and raises private floors, and installs wait a day after a release like the applications' do. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Sep 22, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apps that import kysely directly got a second copy whenever Renovate bumped theirs, because every pgstencil package pinned its own
kysely: 0.29.5. Kysely classes have#privatefields, so the two copies are incompatible types. That is why diffplug/type-the-rhythm#355 fails typecheck.Dependency policy (documented in PACKAGES.md → Dependencies)
kysely(all packages),hono(auth),stripe(stripe, sinceBillingtakes the app'sStripeclient), andpgstencil(auth and stripe, becausepgstencil/diagnosticskeeps request scope inAsyncLocalStorage). Each is also a devDependency, so this workspace still installs and tests it.~1.7.3, patch releases only), jose, openid-client, pg, node-pg-migrate, testcontainers, cheerio, turndown. These now use version ranges instead of exact pins. A new login provider or Better Auth plugin belongs in@pgstencil/auth, not in an app.Renovate
.github/renovate.jsonfollows the other repos' conventions: Monday schedule, release-age cooldowns, majors held for dashboard approval, and avulnerabilityAlertsblock that keeps its cooldown. Library-specific rules:widen. An in-range release only updates the devDependency copy that CI tests; an out-of-range release widens the peer range.bump, which raises the minimum to the version CI tested.kyselyis grouped withkysely-codegen, andhonowith@hono/**.@types/nodeis capped to Node 24.A local
renovate --platform=local --dry-run=lookupshowed peers getting no range updates for in-range releases, kysely 0.29.6 arriving as a lockfile-only change, and better-auth~1.7.3→~1.7.5. The config validates withrenovate-config-validator --strict.pnpm-workspace.yamlalso getsminimumReleaseAge: 1440, matching the apps.packages:verify
The packed consumer now declares each peer at the version the workspace tests, with
auto-install-peers=falseandstrict-peer-dependencies=true. I checked locally that an out-of-range kysely (0.28.11) and a missing hono both fail its install. A missing kysely does not fail, because pnpm fills it from better-auth's own kysely dependency, so there is still only one copy.Testing
pnpm check: format, typecheck, and all 160 testspnpm db:verifypnpm packages:verifyApps
type-the-rhythm and dormouse vendor this commit (
297edf6) in their own PRs. Please merge with a merge commit, as before, so that commit stays in main's history.🤖 Generated with Claude Code