Add tests#17
Conversation
davidlehn
left a comment
There was a problem hiding this comment.
- Should add a github action to run these.
- Is "fixture" term use ok? I thought that was more the broader testing setup vs only the test data here. Can be changed later if needed.
- Should perhaps target a different branch. It's overlapping with other PRs.
Ah. I see. I had the branches stacked locally, but GitHub ignores that when you make a PR... It's possible to later edit that (or maybe set it via the CLI), but I forgot to do that. Sorry for the confusion. |
|
@davidlehn GitHub Action added. Obligatory |
I've changed the base to |
Hit the title edit button and you can change the target branch. |
davidlehn
left a comment
There was a problem hiding this comment.
Getting a bit confused with the multiple prs and what was changed where. Like the node_modules ignore is here too.
Thanks @davidlehn Co-authored-by: David I. Lehn <dil@lehn.org>
fixturestodata.