Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding automated linting and testing to the repository. Hoping to catch undefined global references in extension scripts and ensuring code quality for both our code and the LLM generated code. The main changes include adding a GitHub Actions workflow for CI, integrating ESLint with a custom configuration, and centralizing the discovery of global names used across scripts and tests.
Continuous integration and automation:
.github/workflows/ci.ymlto run tests and linting on every push and pull request, to ensure missing helper functions and similar bugs are caught early, especially for the auto-generatedmap_itemfunctions.Linting infrastructure:
eslint.config.mjswith a configuration that enables theno-undefrule for extension scripts and modules, using a dynamically generated list of global names to avoid false positives.tests/package.jsonto add scripts for running ESLint and included necessary dependencies (eslint,globals).Global name discovery and sharing:
tests/lib-globals.cjs, which extracts global helper names fromjs/lib.jsandjs/zs-background.js, and exposes them for both the test setup and ESLint configuration.tests/setup-globals.cjsto use the shared global name list fromlib-globals.cjs