Update README.rst#302
Conversation
| ``cp -rT ../djangoproject.com/static/js trac-env/htdocs/js`` | ||
| 4. Compile trackhacks.scss: | ||
| ``make compile-scss`` | ||
| ``cp -rT ../djangoproject.com/djangoproject/static/js trac-env/htdocs/js`` |
There was a problem hiding this comment.
The T option didn't worked for me, did it worked for you like that @kehach07 ?
There was a problem hiding this comment.
Hi @sabderemane,
Yes, it worked on my setup. I believe the -rT option was already present before my changes, so I kept it as is.
From what I understand, -T treats the destination as a normal path instead of creating an additional nested directory. If -T is not working on your environment, we could use an alternative such as:
cp -r ../djangoproject.com/djangoproject/static/js/* trac-env/htdocs/js/or
cp -r ../djangoproject.com/djangoproject/static/js/. trac-env/htdocs/js/which should copy the contents into the destination directory without relying on the -T flag.
Let me know what you think.
There was a problem hiding this comment.
Great! I think we could stick to the first one, technically we don't have any dot files in the js folder to copy so worth to stick to the first command.
There was a problem hiding this comment.
thanks , i will update that
There was a problem hiding this comment.
@sabderemane Hi, I’ve made the requested changes. Please let me know if anything else is required.
|
hello @django/ops-team could someone review this PR by any chance? |
jacobtylerwalls
left a comment
There was a problem hiding this comment.
Thank you for sprucing this up! I also struggled, maybe you can help me?
| 4. Compile trachacks.scss:: | ||
| docker compose exec trac make compile-scss | ||
| docker compose restart trac |
There was a problem hiding this comment.
For my own understanding, is the equivalent non-docker command the one given above under the last bullet in "Local install"? (And if so, can we refer there somehow?)
There was a problem hiding this comment.
You are spot on, Jacob! That Docker command does the exact same thing as the local setup.
To save anyone from scrolling back to the top of the file to hunt for it, I've updated this step to include the direct, standalone sassc alternative right here in line. Thanks for catching that!
| ``cp ../djangoproject.com/static/scss/_utils.scss scss/`` | ||
| ``cp ../djangoproject.com/djangoproject/static/css/*.css trac-env/htdocs/css/`` | ||
| 2. Copy _utils.scss (needed by trachacks.scss): | ||
| ``cp ../djangoproject.com/djangoproject/static/scss/_utils.scss scss/`` |
There was a problem hiding this comment.
I must be missing an important step, because I don't have any ../djangoproject.com/djangoproject/static/scss directory. What did I forget?
There was a problem hiding this comment.
Ah, great eyes! You didn't forget a step at all.
The scss folder isn't actually inside the static folder—they are sitting side-by-side as sibling directories inside the inner djangoproject wrapper. I've updated the README to reflect the exact file tree path: ../djangoproject.com/djangoproject/scss/_utils.scss.
docs: resolve pull request feedback by updating scss paths and inline compilation scripts
docs: resolve pull request feedback by updating scss paths and inline compilation scripts
Update README static asset paths and Docker SCSS commands for local Trac setup