Repository navigation
Support inline comment links in review workflows - #28
Merged
Merged
Conversation
Review helpers rejected discussion_r links, preventing direct handling of GitHub Code Quality findings. Preserve the comment selection through fetching, reply validation, resolution, and resume without widening its thread scope. Add regression coverage and synchronize plugin manifests at version 1.1.19. Validated with scripts/check.py, scripts/test.py, and read-only checks against the reported GitHub thread.
Completion snapshots only recognized reviewReference and silently lost the selection for direct comment links. Forward either selection identity to the shared selector so completion audits retain the same thread boundary and reject missing or ambiguous comment matches. Cover resolved-thread selections and invalid matches in completion audit tests.
The legacy GraphQL databaseId field is deprecated and does not guarantee 64-bit identifiers. Query fullDatabaseId for comments and submitted reviews through stable aliases on both pagination paths. Normalize BigInt comment strings to integers so existing snapshots and selection consumers keep their current output contract. Cover realistic large string and integer IDs, including paginated replies.
The pagination fixture returned BigInt values regardless of requested fields, so reverting either query to legacy identifiers remained undetected. Check the outgoing comment and review ID fields on every initial and nested request before accepting the fixture response as coverage. Verify all four field rollback mutations fail the strengthened test. Full repository checks and tests pass, alongside live pagination verification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Review helpers rejected
#discussion_rIDlinks, preventing direct handling of inline findings such as this GitHub Code Quality comment.Fix
Preserve inline comment links through fetching, reply validation, resolution, and resume. Select only the containing thread while retaining complete PR evidence as context; missing or ambiguous matches stop the workflow.
Keep request mappings and mutations within the original selection, reuse verified existing answers, and apply the ordinary guarded workflow to actionable bot findings. Synchronize both host manifests at version 1.1.19.