Repository navigation
ci: pin all actions to commit SHAs, tighten token permissions - #165
Open
theoephraim wants to merge 2 commits into
Open
theoephraim wants to merge 2 commits into
theoephraim wants to merge 2 commits into
Conversation
Pin every `uses:` across the workflows to the full commit SHA each tag resolved to today (no version changes), with a `# vX.Y.Z` comment so Dependabot can bump hash + comment together. Added dependabot.yml for the github-actions ecosystem so the pins don't rot. Also from the audit: - ci.yaml / on-release.yaml had no permissions block; the repo default token permission is write, so they ran with write-all. Now read / none. - on-release.yaml and release.yaml interpolated event/output data directly into run: scripts; moved to env to close shell injection. Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes across the seven workflow and configuration files, including immutable action references, token scopes, shell-expression handling, and automated pin maintenance.
- Immutable action pins — Every
uses:reference is pinned to a full SHA, and each SHA independently resolves to the exact version named in its comment. - Least-privilege tokens —
ci.yamlnow grants onlycontents: read, while the event-only verification workflow grants no token permissions; both remain sufficient for their jobs. - Safer shell inputs — Release metadata and generated package output are passed through step environment variables rather than interpolated into shell source.
- Automated maintenance — Dependabot now groups weekly GitHub Actions updates so the pinned revisions and version comments can remain current.
gpt-5.6-sol | 𝕏
- snapshot example ran unscoped `bunx bumpy`, which fetches a different npm package when bumpy isn't installed locally; use @varlock/bumpy - add contents: read wherever a permissions block is given (a block zeroes the rest, and checkout needs it on private repos), including our own bumpy-comment.yaml - snapshot example: add permissions block, GH_TOKEN instead of GITHUB_TOKEN, checkout/setup-node v6 - publish job: node 24 + npm@11 instead of latest/latest on the one job holding id-token: write - App token snippet: scope minted token with permission-* inputs Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes since the prior Pullfrog review at ed0ee77, covering the trusted commenter permission adjustment and the corrected workflow documentation.
- Expanded trusted commenter access — Added
contents: readso the default-branch checkout also works in private repositories while retaining only the required PR write scope. - Corrected CLI examples — Replaced the stale package invocation and token variable with
@varlock/bumpyandGH_TOKEN, matching the published package and CLI conventions. - Stabilized release tooling examples — Pinned the documented runtime to Node 24 and npm 11 and limited generated GitHub App tokens to the permissions Bumpy needs.
- Updated snapshot guidance — Refreshed checkout/setup-node majors and documented the explicit workflow permissions required for checkout and PR comments.
gpt-5.6-sol | 𝕏
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Audit of
.github/workflows. Everyuses:is now pinned to the full commit SHA its tag resolved to on 2026-10-14, with a# vX.Y.Zcomment. No version changes, so no behavior change.Also from the audit:
ci.yamlandon-release.yamlhad nopermissionsblock. The repo's default workflow token permission iswrite, so they ran with write-all. Nowcontents: readand{}respectively.on-release.yamlechoed release name/tag/author straight into arun:script;release.yamldid the same with the packages output. Both moved toenv.github-actionsecosystem (weekly, grouped) so the SHA pins get bumped together with their version comments.Reviewer notes
pullfrog.ymlsays DO NOT EDIT. Pinned anyway; a pullfrog-managed regeneration may revert it to@v0.node-version: latest+npm install -g npm@lateston the publish job (the one withid-token: write) are unpinned.@vNtags (fine for docs), butdocs/snapshots.mdreferencescheckout@v4/setup-node@v4.🤖 Generated with Claude Code