Skip to content

vendor: github.com/open-policy-agent/opa v1.14.1#3913

Draft
thaJeztah wants to merge 2 commits into
docker:masterfrom
thaJeztah:bump_opa
Draft

vendor: github.com/open-policy-agent/opa v1.14.1#3913
thaJeztah wants to merge 2 commits into
docker:masterfrom
thaJeztah:bump_opa

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

updating to the lowest minor release that contains opa@e9ca3ed, which removed some redundant imports that resulted in indirect dependencies.

full diff: open-policy-agent/opa@v1.10.1...v1.14.1

updating to the lowest minor release that contains [opa@e9ca3ed], which removed
some redundant imports that resulted in indirect dependencies.

full diff: open-policy-agent/opa@v1.10.1...v1.14.1

[opa@e9ca3ed]: open-policy-agent/opa@e9ca3ed

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the added lines are in these JSON files (wondering if they must be in this package, or could be stored separate)

package capabilities

import (
"embed"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, guess they are used in code (through embed) 😞

@thaJeztah thaJeztah Jun 16, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But doesn't appear to increase the size;

┌───────────────────────────────────────────────────────────────────────────────┐
│ Diff between buildx and buildx-after                                          │
├─────────┬─────────────────────────────────────┬──────────┬──────────┬─────────┤
│ PERCENT │ NAME                                │ OLD SIZE │ NEW SIZE │ DIFF    │
├─────────┼─────────────────────────────────────┼──────────┼──────────┼─────────┤
│ +100%   │ github.com/lestrrat-go/option/v2    │          │ 9.5 kB   │ +9.5 kB │
│ +0.29%  │ github.com/lestrrat-go/jwx/v3       │ 1.1 MB   │ 1.1 MB   │ +3.1 kB │
│ +0.51%  │ github.com/vektah/gqlparser/v2      │ 279 kB   │ 280 kB   │ +1.4 kB │
│ +1.67%  │ sigs.k8s.io/yaml                    │ 22 kB    │ 22 kB    │ +359 B  │
│ +0.69%  │ strings                             │ 48 kB    │ 49 kB    │ +334 B  │
│ +0.05%  │ github.com/docker/cli               │ 235 kB   │ 235 kB   │ +116 B  │
│ +0.00%  │ github.com/docker/buildx            │ 2.1 MB   │ 2.1 MB   │ +39 B   │
│ +0.08%  │ github.com/valyala/fastjson         │ 43 kB    │ 43 kB    │ +34 B   │
│ -100%   │ github.com/beorn7/perks             │          │          │ +0 B    │
│ -1.10%  │ sort                                │ 24 kB    │ 24 kB    │ -265 B  │
│ -0.14%  │ math                                │ 234 kB   │ 234 kB   │ -323 B  │
│ -0.36%  │ encoding/xml                        │ 95 kB    │ 95 kB    │ -340 B  │
│ -11.54% │ golang.org/x/sys                    │ 21 kB    │ 18 kB    │ -2.4 kB │
│ -0.27%  │ crypto                              │ 1.5 MB   │ 1.5 MB   │ -4.0 kB │
│ -0.28%  │ go.opentelemetry.io/otel            │ 1.6 MB   │ 1.6 MB   │ -4.7 kB │
│ -1.44%  │ slices                              │ 442 kB   │ 436 kB   │ -6.4 kB │
│ -100%   │ github.com/prometheus/common        │ 7.7 kB   │          │ -7.7 kB │
│ -100%   │ github.com/lestrrat-go/option       │ 11 kB    │          │ -11 kB  │
│ -1.29%  │ runtime                             │ 920 kB   │ 908 kB   │ -12 kB  │
│ -2.03%  │ <unnamed:generated>                 │ 741 kB   │ 726 kB   │ -15 kB  │
│ -100%   │ github.com/go-ini/ini               │ 29 kB    │          │ -29 kB  │
│ -100%   │ github.com/prometheus/client_model  │ 32 kB    │          │ -32 kB  │
│ -2.57%  │ github.com/open-policy-agent/opa    │ 3.6 MB   │ 3.6 MB   │ -94 kB  │
│ -100%   │ github.com/prometheus/client_golang │ 101 kB   │          │ -101 kB │
│ -100%   │ gopkg.in/yaml.v3                    │ 239 kB   │          │ -239 kB │
├─────────┼─────────────────────────────────────┼──────────┼──────────┼─────────┤
│ +3.71%  │ __rodata __TEXT                     │ 6.8 MB   │ 7.0 MB   │ +252 kB │
│ +4.79%  │ __noptrdata __DATA                  │ 1.5 MB   │ 1.5 MB   │ +70 kB  │
│ -1.53%  │ __data __DATA                       │ 349 kB   │ 344 kB   │ -5.3 kB │
│ -0.78%  │ __gopclntab __TEXT                  │ 2.7 MB   │ 2.6 MB   │ -21 kB  │
│ -1.40%  │ __rodata __DATA_CONST               │ 7.2 MB   │ 7.1 MB   │ -101 kB │
├─────────┼─────────────────────────────────────┼──────────┼──────────┼─────────┤
│ -0.61%  │ buildx                              │ 63 MB    │ 62 MB    │ -384 kB │
│         │ buildx-after                        │          │          │         │
└─────────┴─────────────────────────────────────┴──────────┴──────────┴─────────┘

The WithBuiltins method was deprecated in opa v0.23.0 ([opa@afc8c5e]) in
favor of WithCapabilities, but the deprecation didn't use the standard
format, causing it not being detected as deprecated. OPA v1.1.0 corrected
the deprecation in [opa@622434d].

This patch replaces uses of the deprecated functions.

[opa@afc8c5e]: open-policy-agent/opa@afc8c5e
[opa@622434d]: open-policy-agent/opa@622434d

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant