docker-container: wait for BuildKit client readiness - #4027
Merged
crazy-max merged 2 commits intoSep 1, 2026
Conversation
crazy-max
force-pushed
the
fix-docker-container-first-build-race
branch
2 times, most recently
from
August 20, 2026 14:06
3f8e6c6 to
3c9abc6
Compare
crazy-max
marked this pull request as ready for review
August 20, 2026 14:06
This was referenced Aug 20, 2026
crazy-max
force-pushed
the
fix-docker-container-first-build-race
branch
2 times, most recently
from
August 28, 2026 11:52
82259f9 to
833613b
Compare
Only memoize a BuildKit client after driver client creation succeeds. This lets bootstrap retry after transient driver readiness errors instead of keeping the first failed Client call for the lifetime of the handle. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Use the typed client wait during the container startup window. Avoid delaying stopped or established broken builders. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
crazy-max
force-pushed
the
fix-docker-container-first-build-race
branch
from
September 1, 2026 07:17
833613b to
2d4e67c
Compare
crazy-max
changed the title
vvoland
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4021
closes #4023
A freshly created
docker-containerbuilder can report as running beforebuildkitdis ready to serve its socket. Concurrent first builds can then fail with dial-stdio or server preface errors, and a cached failed client creation can make that transient startup failure sticky.This change only caches successfully created driver clients and makes the
docker-containerdriver wait for BuildKit readiness during the container startup window before returning a client. Established broken builders still fail promptly, while newly started builders get a bounded readiness wait through BuildKit's typed client API.