Repository navigation
refactor(scheduler): scope worker lifetime to blocking Run(ctx) - #4705
Merged
Merged
Conversation
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
trungutt
approved these changes
Oct 22, 2026
melmennaoui
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The scheduler's worker lifetime was owned by separate
Start/Stopcalls,which made lifecycle ownership (who starts, who stops, who owns restarts)
hard to reason about across nested tools and forked sessions, and left gaps
where completion/restart/probe signals could race or be lost.
What
Start/Stopworker ownership with a single blockingRun(ctx)on the scheduler; the worker's lifetime is now scoped to thatcall and tied to context cancellation.
tools.Runnableas the canonical host bridge for this model, andmigrate all callers: normal and additional toolsets, Code Mode, the
fork-skill path, and raw session extras.
Stop.
ownership, and probe non-blocking behavior, and distinguish lifecycle
contention from actual signal loss.
Validation
CI=true task build,task test,task lintall pass.tools,codemode,agent,runtime,teamloader,scheduler) repeated 10x.SplitGoroutineLifetimeaudit via temporary overlay: 9 warnings, downfrom 10 (scheduler's removed); the checker remains disabled globally.
No further code changes intended in this PR.