Repository navigation
fix(desktop): preserve secrets-engine auth fallback behavior - #4707
Merged
Merged
Conversation
SecretsEngineError no longer blocks on an in-flight lookup, so callers get an immediate "slow" error instead of stalling; the stalled engine still keeps serving the legacy account info in the meantime. Expiry checks for live and cached sessions now go through the shared skew-aware ExpiringAt helper instead of duplicating the leeway math. Staging host detection for DNS hosts is now case-insensitive. Adds coverage against a real secrets-engine SDK client for missing socket, 404, and 501 responses to confirm the legacy fallback kicks in. Assisted-By: docker-agent
trungutt
approved these changes
Oct 22, 2026
aheritier
added
area/security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #4535. Preserves legacy auth fallback behavior now that the secrets-engine path is in
main:SecretsEngineErrorreturns a nonblocking snapshot instead of blocking on an in-flight lookup, so a slow/stalled engine can no longer stall debug auth or lose the legacy account info while a lookup is pending.hubauth.ExpiringAthelper (issuer-corrected time + skew leeway) instead of duplicating the leeway math.Tests
task build,task test,task lint(0 issues)go test -race ./pkg/desktop ./pkg/environment ./pkg/hubauth ./pkg/sandbox ./cmd/rootpkg/desktopandpkg/hubauthpkg/desktoptests, linux/arm64 build ofpkg/desktop+pkg/hubauth, js/wasm build ofcmd