fix(uve): forward all page params (mode, language, persona, variant, time machine) to Page Health scanner

[fmontes]

What

The UVE Page Health a11y/GEO scanner only received the page path and host_id, so dotCMS re-resolved the page against defaults — always scanning the published page in the default language/persona/variant, regardless of the state open in the editor. Users could not scan a draft before publishing, which is a primary documented benefit of the feature.

This forwards every page-resolving param onto the scanned URL so the scanner re-renders exactly what the editor is showing:

• mode — draft/preview/live, so unpublished pages scan in the correct state
• language_id, persona, variantName — match the editor selection
• publishDate — Future Time Machine
• host_id — multisite (existing behavior from fix(uve): scan correct site in Page Health a11y/GEO reports on multisite #36163)

Editor-fetch-only params (clientHost, depth, url) are excluded so they don't leak to the public scanner. The default variant and default persona are dropped via normalizeQueryParams, matching the rest of the editor.

Scope

• dot-ema-shell.component.ts — handleScannerToolClick() appends the page params; new #getScannerPageParams() helper builds them from uveStore.pageParams() using the DotPageAssetKeys enum.
• dot-ema-shell.component.spec.ts — assert all params are forwarded, editor-fetch params are excluded, and default variant/persona are dropped.

No backend changes: the scanner fetches the URL verbatim, so the params survive the round-trip.

Closes #36183

[claude]

Claude finished @fmontes's task in 1m 19s —— View job

---

Rollback Safety Analysis

• Read rollback-unsafe categories reference
• Get full PR diff
• Analyze diff against unsafe categories
• Apply appropriate label

---

Verdict: ✅ Safe to Roll Back

All changes in this PR are confined to two frontend Angular TypeScript files:

File	Change
dot-ema-shell.component.ts	Adds #getScannerPageParams() helper; appends page-resolving params to scanner URL
dot-ema-shell.component.spec.ts	Updates and expands unit tests

Analysis against all rollback-unsafe categories:

Category	Finding
C-1 Structural Data Model	No DB schema changes
C-2 Elasticsearch Mapping	No ES mapping changes
C-3 Content JSON Model Version	No CURRENT_MODEL_VERSION bump
C-4 DROP TABLE/COLUMN	No DDL drops
H-1 One-Way Data Migration	No data migrations
H-2 RENAME TABLE/COLUMN	No renames
H-3 PK Restructuring	No PK changes
H-4 New Field Type	No new field types
H-5 Storage Provider	No storage config changes
H-6 DROP PROCEDURE/FUNCTION	No stored procedure changes
H-7 NOT NULL without default	No schema changes
H-8 VTL Viewtool Contract	No viewtool changes
M-1 Column Type Change	No schema changes
M-2 Push Publishing Bundle	No bundle format changes
M-3 REST/GraphQL Contract	No API contract changes — only forwarding existing query params to existing scanner endpoint
M-4 OSGi Interface	No OSGi changes

Rollback behavior: Rolling back to N-1 reverts to the previous scanner behavior — the scanner receives only the page path and host_id, falling back to defaults (published page, default language/persona/variant). This is a functional regression (the PR's fix is lost) but causes no data loss, no errors, and no broken state.

Label applied: AI: Safe To Rollback

[github-actions]

❌ Codex Review failed — openai.gpt-5.5

The review job failed before producing output. See the run for details.

_{Run: #27589877061}

[github-actions]

🤖 Bedrock Review — deepseek.v3.2

[🟡 Medium] core-web/libs/portlets/edit-ema/portlet/src/lib/dot-ema-shell/dot-ema-shell.component.ts:357 — The comment incorrectly states that personaId is the SPA-friendly key, but the code uses PERSONA_KEY (which is com.dotmarketing.persona.id). This is a documentation mismatch that could mislead developers about the correct parameter key for backend persona handling.

[🟡 Medium] core-web/libs/portlets/edit-ema/portlet/src/lib/dot-ema-shell/dot-ema-shell.component.ts:395 — The method #getScannerPageParams() filters out empty strings, but params.publishDate could be an empty string from the store. This is fine, but note that the comment says publishDate is forwarded, yet an empty value would be omitted, which might be intentional but is not documented.

[🟡 Medium] core-web/libs/portlets/edit-ema/portlet/src/lib/dot-ema-shell/dot-ema-shell.component.ts:401 — The check persona && persona !== DEFAULT_PERSONA.identifier could fail if persona is an empty string or null/undefined. The persona variable is taken from params[PERSONA_KEY], which may not be defined, but the guard persona handles falsy values correctly.

[🟡 Medium] core-web/libs/portlets/edit-ema/portlet/src/lib/dot-ema-shell/dot-ema-shell.component.ts:406 — The check params.variantName && params.variantName !== DEFAULT_VARIANT_ID assumes params.variantName is a string. If it's null or undefined, it's correctly omitted, but the type DotPageAssetParams should be verified to ensure variantName can be nullable.

[🟡 Medium] core-web/libs/portlets/edit-ema/portlet/src/lib/dot-ema-shell/dot-ema-shell.component.spec.ts:1562 — The test 'should forward all page-resolving params...' includes a publishDate value of '2026-06-15'. Ensure the date format matches what the backend expects (ISO-like string) and that it's not a placeholder that could cause time-machine rendering issues.

[🟡 Medium] core-web/libs/portlets/edit-ema/portlet/src/lib/dot-ema-shell/dot-ema-shell.component.spec.ts:1591 — The test 'should omit the default variant from the scanned URL' uses DEFAULT_VARIANT_ID and DEFAULT_PERSONA.identifier. Verify these constants are correctly imported and match the values used in the component logic to avoid false-positive tests.

---

_{Run: #27633569135 · tokens: in: 3047 · out: 605 · total: 3652}

[Copilot]

Pull request overview

This PR updates the UVE Page Health (a11y/GEO) scanner launch URL so it forwards the editor’s page-resolving state (mode, language, persona, variant, and time machine date), ensuring the scanner renders and scans the same page state the user is viewing in the editor rather than defaulting to published/default selections.

Changes:

• Append editor page-resolving params to the scanner URL via a new helper (#getScannerPageParams()).
• Normalize/omit default selections (default persona/variant) to keep the scanned URL clean.
• Extend unit tests to assert forwarded params and ensure editor-fetch-only params aren’t leaked.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
core-web/libs/portlets/edit-ema/portlet/src/lib/dot-ema-shell/dot-ema-shell.component.ts	Adds helper to forward page-resolving params onto the scanner URL.
core-web/libs/portlets/edit-ema/portlet/src/lib/dot-ema-shell/dot-ema-shell.component.spec.ts	Adds assertions that all relevant params are forwarded and editor-only params are excluded.

[fmontes]

Good catch @copilot — confirmed against the backend. The scanner URL is fetched and rendered by dotCMS (VisitorAPIImpl reads request.getParameter(WebKeys.CMS_PERSONA_PARAMETER) = com.dotmarketing.persona.id), so the SPA-friendly personaId would have been silently ignored.

Fixed in 9c54843: dropped normalizeQueryParams for the scanner params and now send the persona under com.dotmarketing.persona.id directly, dropping the default persona/variant manually. Tests and JSDoc updated to assert the backend key. All four comments are addressed by this change.

[Copilot]

Good catch @copilot — confirmed against the backend. The scanner URL is fetched and rendered by dotCMS (VisitorAPIImpl reads request.getParameter(WebKeys.CMS_PERSONA_PARAMETER) = `com.dotmarketi...

Verified — PERSONA_KEY (com.dotmarketing.persona.id) is used directly in both the implementation and the test assertions, normalizeQueryParams is gone from the scanner path, and all 1300 tests pass.