Skip to content

fix: preserve incoming Anthropic beta headers #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkazlauskas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: preserve incoming Anthropic beta headers #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions src/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import { extractOAuthErrorDetail } from "./oauth.js";
import { selectClaudeCredentials } from "./keychain.js";
import {
default as pluginModule,
buildBetaFlags,
deriveModelDisplayName,
getClaudeToolsForActiveOpenCodeTools,
getInboundToolNameMapForActiveOpenCodeTools,
Expand All @@ -31,6 +32,36 @@ import {
stripSystemCacheControl,
} from "./index.js";
import { createSseProcessor, parseSseEvent, buildSseEvent } from "./stream.js";
import { BETA_FLAGS, OAUTH_BETA_FLAG } from "./constants.js";

describe("Anthropic beta headers", () => {
it("preserves SDK beta flags alongside the bridge requirements", () => {
const sdkBeta = "thinking-binding-controls-test";
const flags = buildBetaFlags(sdkBeta).split(",");
assert.ok(flags.includes(sdkBeta), "request-body feature betas must survive rewriting");
assert.deepEqual(flags.slice(0, 2), ["claude-code-20250219", OAUTH_BETA_FLAG]);
for (const flag of BETA_FLAGS.split(",").map((value) => value.trim()).filter(Boolean)) {
assert.ok(flags.includes(flag), `missing configured beta: ${flag}`);
}
});

it("deduplicates overlapping flags and removes whitespace and empty entries", () => {
const flags = buildBetaFlags(
` , ${OAUTH_BETA_FLAG}, claude-code-20250219, ${BETA_FLAGS}, sdk-test, sdk-test, , `,
).split(",");
assert.equal(flags.length, new Set(flags).size);
assert.ok(flags.every((flag) => flag.length > 0 && flag === flag.trim()));
assert.ok(flags.includes("sdk-test"));
});

it("keeps the bridge requirements when no incoming beta header is present", () => {
assert.deepEqual(buildBetaFlags("").split(","), [...new Set([
"claude-code-20250219",
OAUTH_BETA_FLAG,
...BETA_FLAGS.split(",").map((flag) => flag.trim()).filter(Boolean),
])]);
});
});

// ── Helpers (extracted / reimplemented from index.ts for unit testing) ────────

Expand Down
15 changes: 9 additions & 6 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,12 +453,15 @@ function mergeHeaders(target: Headers, source: HeadersInit) {
}

/** Build deduplicated beta flags string. */
function buildBetaFlags(existing: string): string {
const required = BETA_FLAGS.split(",").map((b) => b.trim()).filter(Boolean);
const withoutSpecials = required.filter(
(beta) => beta !== "claude-code-20250219" && beta !== OAUTH_BETA_FLAG,
);
return ["claude-code-20250219", OAUTH_BETA_FLAG, ...withoutSpecials].join(",");
export function buildBetaFlags(existing: string): string {
// Preserve SDK betas that enable fields already present in the request body.
const flags = [
"claude-code-20250219",
OAUTH_BETA_FLAG,
...BETA_FLAGS.split(","),
...existing.split(","),
];
return [...new Set(flags.map((flag) => flag.trim()).filter(Boolean))].join(",");
}

/** Deduplicate repeated Claude Code prefix in a text block. */
Expand Down