contact form backend - #247
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #247 +/- ##
=============================================
+ Coverage 60.58% 62.40% +1.82%
- Complexity 558 593 +35
=============================================
Files 91 95 +4
Lines 2187 2293 +106
=============================================
+ Hits 1325 1431 +106
Misses 862 862 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
again factory ? |
|
@alexmerlin please confrim that the code is correct here , i feel that i am missing something |
alexmerlin
left a comment
There was a problem hiding this comment.
I would swap the two handler names:
src/App/src/Handler/GetContactCreateFormHandler.php->src/App/src/Handler/GetCreateContactFormHandler.phpsrc/App/src/Handler/PostContactCreateHandler.php-> src/App/src/Handler/PostCreateContactHandler.php
So, it follows the general pattern we use across Dotkernel - see example.
|
@OStefan2001 Please fix your local development environment to use the credentials from this account, because right now you use one account for committing/pushing code and another one for managing issues/PRs in the browser. |
Update $contactEmail from config/autoload/mail.global.php