Skip to content

contact form backend - #247

Merged
arhimede merged 7 commits into
developfrom
contact-form
Sep 30, 2026
Merged

arhimede merged 7 commits into
developfrom
contact-form

Conversation

@OStefan2001

Copy link
Copy Markdown
Collaborator

Update $contactEmail from config/autoload/mail.global.php

@OStefan2001
OStefan2001 requested a review from bidi47 September 25, 2026 14:56
@codecov

codecov Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.40%. Comparing base (774eb82) to head (c4c081b).
⚠️ Report is 7 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #247      +/-   ##
=============================================
+ Coverage      60.58%   62.40%   +1.82%     
- Complexity       558      593      +35     
=============================================
  Files             91       95       +4     
  Lines           2187     2293     +106     
=============================================
+ Hits            1325     1431     +106     
  Misses           862      862              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OStefan2001 OStefan2001 linked an issue Sep 25, 2026 that may be closed by this pull request
@arhimede

Copy link
Copy Markdown
Member

again factory ?
why not inject ?

@arhimede

Copy link
Copy Markdown
Member

@alexmerlin please confrim that the code is correct here , i feel that i am missing something

Comment thread src/App/src/Handler/PostContactCreateHandler.php Outdated
Comment thread src/App/src/Service/ContactService.php Outdated
Comment thread src/Page/src/Handler/GetPageViewHandler.php

@alexmerlin alexmerlin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would swap the two handler names:

  • src/App/src/Handler/GetContactCreateFormHandler.php -> src/App/src/Handler/GetCreateContactFormHandler.php
  • src/App/src/Handler/PostContactCreateHandler.php -> src/App/src/Handler/PostCreateContactHandler.php

So, it follows the general pattern we use across Dotkernel - see example.

Comment thread src/App/src/Handler/PostContactCreateHandler.php Outdated
Comment thread src/App/src/Service/ContactService.php Outdated
Comment thread src/App/src/RoutesDelegator.php Outdated
@alexmerlin

Copy link
Copy Markdown
Member

@OStefan2001 Please fix your local development environment to use the credentials from this account, because right now you use one account for committing/pushing code and another one for managing issues/PRs in the browser.

@arhimede
arhimede merged commit dbe26af into develop Sep 30, 2026
17 checks passed
@alexmerlin
alexmerlin deleted the contact-form branch September 30, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

extend contact us page

3 participants