Repository navigation
Conversation
|
/bindings * |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 608e97e |
Silk.NET bindings regeneration reminderSome of the bindings are likely affected by this PR. If you believe this to be in error, then please write a comment explaining why and ignore this reminder. |
| // Create all jobs | ||
| var jobs = _jobDefinitions.ToDictionary( | ||
| jobKvp => jobKvp.Key, | ||
| jobKvp => | ||
| { | ||
| return new SilkTouchJob( |
There was a problem hiding this comment.
Side effect of needing to ask mods for the command lines is that you have to create all jobs/mods up front. This is arguably fine since jobs/mods are lightweight until they run.
| /// <summary> | ||
| /// Dependencies defined here will be available to jobs. | ||
| /// </summary> | ||
| private void ConfigureForward(IServiceProvider host, IServiceCollection services) |
There was a problem hiding this comment.
MSDI requires explicit forwarding since no parent/child container support.
| <PackageVersion | ||
| Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" | ||
| Version="5.0.0-1.25277.114" | ||
| /> |
There was a problem hiding this comment.
Just CSharpier reformatting outside of removing Autofac here.
|
|
||
| builder.SetMinimumLevel(ctx.ParseResult.GetValueForOption(LoggingOption)); | ||
| // This avoids depending on the CLI options during container building | ||
| builder.AddFilter(IsLogLevelEnabled); |
There was a problem hiding this comment.
We can't set the default minimum level using SetMinimumLevel anymore since that depends on the CLI args and the container is built before CLI args are parsed now.
This seems to be the only way to do it.
|
/bindings * |
Summary of the PR
This removes Autofac and goes back to using just MSDI
Related issues, Discord discussions, or proposals
Links go here.
Further Comments
Tasks
Abstract out DI container from the public API so we aren't locked into a specific framework.See discussion here: https://discord.com/channels/521092042781229087/587346162802229298/1561387300443791481ICommandLineConfigurableinterface with methods for registering CLI options and reading options