Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Author
|
suggested labels: |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change correctly prevents profile-driven working-directory changes without affecting build behavior.
Pull request overview
Adds -NoProfile to prevent developer PowerShell profiles from interfering with documentation trimming during builds.
Changes:
- Runs
TrimDocs.ps1without loading PowerShell profiles. - Resolves the build failure described in #4701.
File summaries
| File | Description |
|---|---|
src/Microsoft.Data.SqlClient/ref/Microsoft.Data.SqlClient.csproj |
Adds -NoProfile to the PowerShell invocation. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
-NoProfileswitch when invokingtools/intellisense/TrimDocs.ps1viapwsh.This flag prevents the developer's profile from interfering with the invocation — for example, by changing the current directory to something unexpected.
Issues
Fixes #4701 .
Testing
No behavior or API change. This PR is testable by
dotnet builditself.The build should succeed.