[7.1.1 Cherry-pick] Preserve in-flight opens when clearing connection pools - #4740
Merged
Merged
Conversation
* Fix OpenAsync retry after pool clear Route pending async opens on a cleared wait-handle pool back through the connection factory so they can complete from the replacement pool instead of surfacing a misleading pool timeout. Add a regression test that parks an async pending open, clears the pool group, and verifies completion from a replacement pool. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Preserve in-flight opens when clearing wait-handle pools Remove shutdown interruption and retry routing. Let admitted requests finish on the retired pool and dispose their connections on return. Preserve error expiry for remaining waiters. Cover sync and async clearing, cancellation, timeouts, and error expiry. Add a SQL Server regression workload for #4714. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Make pool-clear regression coverage deterministic Remove the concurrent stress workload and elapsed-time assertions. Gate physical creation and assert exact request ordering and creation counts around pool shutdown. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Remove pool-clearing documentation changes Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Leave retired pool clearing to the factory Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Clarify gated pool shutdown test scenario Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Separate pool-clear scenario from test plumbing Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Organize pool regression tests as arrange act assert Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Explain pool regression test interleavings inline Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Trim blocking-period test commentary Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Explain regression conditions and assertion evidence Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Clarify shutdown test walkthrough Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Match pool-clear comments to shutdown walkthrough Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
mdaigle
approved these changes
Sep 23, 2026
cheenamalhotra
approved these changes
Sep 23, 2026
mdaigle
enabled auto-merge (squash)
September 23, 2026 18:19
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/7.1 #4740 +/- ##
===============================================
- Coverage 66.39% 64.12% -2.27%
===============================================
Files 291 285 -6
Lines 45110 68055 +22945
===============================================
+ Hits 29949 43639 +13690
- Misses 15161 24416 +9255
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #4718 (3160bb2) into
release/7.1.