Skip to content

LEGO: Pull request from juno/hb_6dddf33b-c6da-43d8-ac04-14d2c339cb00_20260920103314424 to main - #12837

Merged
jonathanpeppers merged 1 commit into
mainfrom
juno/hb_6dddf33b-c6da-43d8-ac04-14d2c339cb00_20260920103314424
Sep 21, 2026
Merged

jonathanpeppers merged 1 commit into
mainfrom
juno/hb_6dddf33b-c6da-43d8-ac04-14d2c339cb00_20260920103314424

Conversation

@csigs

@csigs csigs commented Sep 20, 2026

Copy link
Copy Markdown
Member

LEGO: Pull request from juno/hb_6dddf33b-c6da-43d8-ac04-14d2c339cb00_20260920103314424 to main with localized lcls

Copilot AI lite review requested due to automatic review settings September 20, 2026 10:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The PR modifies Localize/loc/**/*.lcl files, which repo guidance treats as localization pipeline outputs (and also introduces incorrect localization of the literal @(Reference) token in some locales).

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2 Medium severity · 12 Low severity

Open (14)
What changed in this PR

This PR updates localized .lcl resources for Xamarin.Android.Build.Tasks by adding a new localized entry for error message XA1037 (“Unsupported @(Reference) item: {0}”) across multiple languages.

Changes:

  • Added a new XA1037 entry in multiple Localize/loc/**/Resources.resx.lcl files.
  • Introduced localized text for the XA1037 resource in each affected locale.
  • (Locale-specific) Some translations alter the literal MSBuild item token @(Reference).
File Description
Localize/​loc/​cs/​src/​Xamarin.Android.Build.Tasks/​Properties/​Resources.resx.lcl Adds localized XA1037 entry
Localize/​loc/​de/​src/​Xamarin.Android.Build.Tasks/​Properties/​Resources.resx.lcl Adds localized XA1037 entry
Localize/​loc/​es/​src/​Xamarin.Android.Build.Tasks/​Properties/​Resources.resx.lcl Adds localized XA1037 entry
Localize/​loc/​fr/​src/​Xamarin.Android.Build.Tasks/​Properties/​Resources.resx.lcl Adds localized XA1037 entry
Localize/​loc/​it/​src/​Xamarin.Android.Build.Tasks/​Properties/​Resources.resx.lcl Adds localized XA1037 entry
Localize/​loc/​ja/​src/​Xamarin.Android.Build.Tasks/​Properties/​Resources.resx.lcl Adds localized XA1037 entry
Localize/​loc/​ko/​src/​Xamarin.Android.Build.Tasks/​Properties/​Resources.resx.lcl Adds localized XA1037 entry (also alters @(Reference) token)
Localize/​loc/​pl/​src/​Xamarin.Android.Build.Tasks/​Properties/​Resources.resx.lcl Adds localized XA1037 entry
Localize/​loc/​pt-BR/​src/​Xamarin.Android.Build.Tasks/​Properties/​Resources.resx.lcl Adds localized XA1037 entry
Localize/​loc/​ru/​src/​Xamarin.Android.Build.Tasks/​Properties/​Resources.resx.lcl Adds localized XA1037 entry
Localize/​loc/​tr/​src/​Xamarin.Android.Build.Tasks/​Properties/​Resources.resx.lcl Adds localized XA1037 entry (also alters @(Reference) token)
Localize/​loc/​zh-Hant/​src/​Xamarin.Android.Build.Tasks/​Properties/​Resources.resx.lcl Adds localized XA1037 entry

<Str Cat="Text">
<Val><![CDATA[Unsupported @(Reference) item: {0}]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[지원되지 않는 @(참조) 항목: {0}]]></Val>
<Str Cat="Text">
<Val><![CDATA[Unsupported @(Reference) item: {0}]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Desteklenmeyen @(Başvuru) öğesi: {0}]]></Val>
Comment on lines +861 to +865
<Item ItemId=";XA1037" ItemType="0;.resx" PsrId="211" InstFlg="true" Leaf="true">
<Str Cat="Text">
<Val><![CDATA[Unsupported @(Reference) item: {0}]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Nepodporovaná položka @(Reference): {0}]]></Val>
Comment on lines +861 to +865
<Item ItemId=";XA1037" ItemType="0;.resx" PsrId="211" InstFlg="true" Leaf="true">
<Str Cat="Text">
<Val><![CDATA[Unsupported @(Reference) item: {0}]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Nicht unterstütztes @(Reference)-Element: {0}]]></Val>
Comment on lines +861 to +865
<Item ItemId=";XA1037" ItemType="0;.resx" PsrId="211" InstFlg="true" Leaf="true">
<Str Cat="Text">
<Val><![CDATA[Unsupported @(Reference) item: {0}]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Elemento @(Reference) no admitido: {0}]]></Val>
Comment on lines +861 to +865
<Item ItemId=";XA1037" ItemType="0;.resx" PsrId="211" InstFlg="true" Leaf="true">
<Str Cat="Text">
<Val><![CDATA[Unsupported @(Reference) item: {0}]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Nieobsługiwany element @(Reference): {0}]]></Val>
Comment on lines +861 to +865
<Item ItemId=";XA1037" ItemType="0;.resx" PsrId="211" InstFlg="true" Leaf="true">
<Str Cat="Text">
<Val><![CDATA[Unsupported @(Reference) item: {0}]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Item @(Reference) sem suporte: {0}]]></Val>
Comment on lines +861 to +865
<Item ItemId=";XA1037" ItemType="0;.resx" PsrId="211" InstFlg="true" Leaf="true">
<Str Cat="Text">
<Val><![CDATA[Unsupported @(Reference) item: {0}]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Неподдерживаемый элемент @(Reference): {0}]]></Val>
Comment on lines +861 to +865
<Item ItemId=";XA1037" ItemType="0;.resx" PsrId="211" InstFlg="true" Leaf="true">
<Str Cat="Text">
<Val><![CDATA[Unsupported @(Reference) item: {0}]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Desteklenmeyen @(Başvuru) öğesi: {0}]]></Val>
Comment on lines +861 to +865
<Item ItemId=";XA1037" ItemType="0;.resx" PsrId="211" InstFlg="true" Leaf="true">
<Str Cat="Text">
<Val><![CDATA[Unsupported @(Reference) item: {0}]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[不支援的 @(Reference) 項目: {0}]]></Val>
@jonathanpeppers
jonathanpeppers merged commit e880866 into main Sep 21, 2026
45 checks passed
@jonathanpeppers
jonathanpeppers deleted the juno/hb_6dddf33b-c6da-43d8-ac04-14d2c339cb00_20260920103314424 branch September 21, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants