Fix parent non-recursive arguments leaking into subcommands (#2785)#2809
Open
AhmedMyoussif wants to merge 2 commits into
Open
Fix parent non-recursive arguments leaking into subcommands (#2785)#2809AhmedMyoussif wants to merge 2 commits into
AhmedMyoussif wants to merge 2 commits into
Conversation
Author
|
@dotnet-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves issue #2785 where non-recursive positional arguments from parent commands were incorrectly inherited, validated, and displayed in subcommands.
Key Changes
ParseOperation: IntroducedMoveNonRecursiveParentArgumentsToUnmatchedinsideParseSubcommand(). When entering a subcommand, the parser immediately intercepts parent arguments configured withRecursive = false, purges them from theSymbolResultTree, and registers their tokens asUnmatchedTokensunder the root command result. This completely prevents validation leaks and downstream crashes.HelpBuilder.cs(GetUsagePartsandGetCommandArgumentRows) to filter out parent arguments whereRecursive == falsewhen rendering usage strings and argument tables for subcommands.Recursiveproperty to theArgumentclass (defaulting totrueto avoid breaking changes) and updated the alphabetical baseline file for API compatibility checks.ParserTests.cs) and layout rendering accuracy (HelpBuilderTests.cs).Verification
net10.0target.