Skip to content

Update snippets 5000 container - #56874

Merged
BillWagner merged 3 commits into
mainfrom
update-container
Nov 12, 2026
Merged

BillWagner merged 3 commits into
mainfrom
update-container

Conversation

@BillWagner

@BillWagner BillWagner commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

The container image for the Snippets 5000 needed to be updated in order to use the latest Visual Studio installation, which is required to use the .NET 11 SDK.

Test run is here: https://github.com/dotnet/docs/actions/runs/43130284811. Note that there are failures, but that's due to the updates in #56872, which can be addressed once this is merged.


Build report

This image is needed to access the latest version of Visual Studio (dev 18)
Copilot AI balanced review requested due to automatic review settings November 12, 2026 01:17
@dotnetrepoman dotnetrepoman Bot added this to the November 2026 milestone Nov 12, 2026
@BillWagner
BillWagner enabled auto-merge (squash) November 12, 2026 01:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Manual runs check out the selected workflow branch rather than the supplied PR, so Snippets5000 can validate the wrong code or miss newly added projects.

1 open issue
What changed in this PR

Updates the Snippets 5000 validation workflow to use a Windows runner intended to provide the Visual Studio installation required by the .NET 11 SDK.

Changes:

  • Switches the runner from windows-2022 to windows-11-arm.
  • Adds a required PR-number input for manual runs and passes it to Snippets5000.
File Description
.github/​workflows/​snippets5000.yml Updates the runner and adds manual PR selection for snippet validation.

Review effort: Balanced

Comment thread .github/workflows/snippets5000.yml Resolved
@BillWagner
BillWagner requested a review from gewarren November 12, 2026 13:50
@BillWagner
BillWagner merged commit abe4b55 into main Nov 12, 2026
15 of 16 checks passed
@BillWagner
BillWagner deleted the update-container branch November 12, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants