Repository navigation
Conversation
eerhardt
reviewed
Nov 12, 2026
Comment on lines
+15
to
+16
| <PackageVersion Include="Aspire.Npgsql" Version="13.6.5" /> | ||
| <PackageVersion Include="Aspire.Npgsql.EntityFrameworkCore.PostgreSQL" Version="13.6.5" /> |
Member
There was a problem hiding this comment.
Can we update these to 17 preview?
Member
Author
There was a problem hiding this comment.
It was a bug, I'm about to push the fix.
eerhardt
reviewed
Nov 12, 2026
Comment on lines
+17
to
+19
| <PackageVersion Include="Aspire.RabbitMQ.Client" Version="13.6.5" /> | ||
| <PackageVersion Include="Aspire.StackExchange.Redis" Version="13.6.5" /> | ||
| <PackageVersion Include="Aspire.Azure.AI.OpenAI" Version="13.6.5-preview.1.26559.7" /> |
eerhardt
reviewed
Nov 12, 2026
| <PackageVersion Include="Microsoft.Extensions.Options" Version="10.0.12" /> | ||
| <PackageVersion Include="Microsoft.Extensions.Configuration.Abstractions" Version="10.0.12" /> | ||
| <PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.12" /> | ||
| <PackageVersion Include="Microsoft.Extensions.Options" Version="10.0.15" /> |
Member
There was a problem hiding this comment.
I assume we are doing net11 migration later?
eerhardt
reviewed
Nov 12, 2026
| } No newline at end of file | ||
| "version": "17.0.0" | ||
| }, | ||
| "channel": "staging" |
Member
There was a problem hiding this comment.
we will want to revert this when it is time
eerhardt
reviewed
Nov 12, 2026
| { | ||
| var encoded = result.Properties.Items["client_list"]; | ||
| var bytes = Base64Url.Decode(encoded); | ||
| var bytes = System.Buffers.Text.Base64Url.DecodeFromChars(encoded); |
Member
Author
There was a problem hiding this comment.
The API we were calling was from Duende.IdentityModel, which was removed in the new version, so this moves to use .NET's version instead.
eerhardt
reviewed
Nov 12, 2026
| @@ -1,4 +1,4 @@ | |||
| <Project Sdk="Aspire.AppHost.Sdk/13.6.0"> | |||
| <Project Sdk="Aspire.AppHost.Sdk/17.0.0"> | |||
Member
There was a problem hiding this comment.
CAn we get rid of the SDK altogether now, right?
Member
Author
There was a problem hiding this comment.
Yes, I just haven't run that skill yet.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge status
Do not merge yet. This draft prepares eShop for Aspire 17.0 using staging builds. We want to merge this only after the stable Aspire 17.0 release is available. Before merging, switch to the stable release and remove any staging-only package feed/channel configuration that is no longer needed.
Summary