Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
@AndriySvyryd PTAL |
Contributor
There was a problem hiding this comment.
Pull request overview
Enables Arcade’s Helix Job Monitor in EF Core’s public and internal Azure DevOps pipelines so Helix submission jobs can stop after queueing, while a dedicated monitor job publishes test results and drives the final Helix status.
Changes:
- Add
Microsoft.DotNet.Helix.JobMonitordependency/version plumbing and pin the tool via.config/dotnet-tools.json. - Enable Helix Job Monitor behavior in
eng/helix.projwhenSYSTEM_ACCESSTOKENis available. - Add the
helix-job-monitor.ymljob template to both public and internal pipelines.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| eng/Version.Details.xml | Adds Helix Job Monitor dependency tracking entry. |
| eng/Version.Details.props | Introduces Helix Job Monitor version properties alongside other dotnet-dotnet dependencies. |
| eng/helix.proj | Turns on Helix Job Monitor mode when SYSTEM_ACCESSTOKEN is set. |
| azure-pipelines-public.yml | Adds Helix Job Monitor job template to the public pipeline (currently with an indentation issue). |
| azure-pipelines-internal-tests.yml | Adds Helix Job Monitor job template to the internal test pipeline and passes helixAccessToken. |
| .config/dotnet-tools.json | Pins the dotnet-helix-job-monitor tool version for dotnet tool restore. |
AndriySvyryd
reviewed
Aug 5, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wtgodbe
marked this pull request as draft
August 6, 2026 17:36
Preserve the Helix job monitor validation while retaining the retry aggregation improvements from main. Update the new JobMonitor dependency to the current dotnet build versions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Monitor job dependencies and no-Helix-job handling must be corrected in both pipelines.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 4
- Review effort level: Lite
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Both pipeline monitor jobs can run before Helix submissions; add explicit dependencies and use always().
Review details
Suppressed comments (2)
Previously missed (2) — in code that hasn't changed since the last review.
azure-pipelines-internal-tests.yml:667
- This invocation leaves the monitor's
dependsOnat its[]default, so Azure DevOps can startHelixJobMonitorin parallel with theHelix_*submission jobs; list order does not create a dependency. It can therefore observe no queued work and finish before the submitters release their agents. Pass explicit dependencies on the Helix jobs and usealways()so skipped jobs in filtered runs do not suppress the monitor.
azure-pipelines-public.yml:531 - This invocation leaves the monitor's
dependsOnat its[]default, so Azure DevOps can startHelixJobMonitorin parallel with theHelix_*submission jobs; list order does not create a dependency. It can therefore observe no queued work and finish before the submitters release their agents. Pass explicit dependencies on the Helix jobs and usealways()so skipped jobs in filtered runs do not suppress the monitor.
- Files reviewed: 6/6 changed files
- Comments generated: 0 new
- Review effort level: Lite
Use the Job Monitor's per-queue failed-work-item attachments so grouped validation and selective retries retain their existing semantics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Filtered Helix-only runs omit validation while the monitor continues on error, allowing Helix test failures to pass the pipeline.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 2
- Review effort level: Lite
AndriySvyryd
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable Arcade's Helix Job Monitor for the public and internal test pipelines. Helix submission jobs can now release their agents after queueing work, while the monitor publishes test results and owns the final Helix status.