Report correct runtime commit for SDK measurements - #5290
Open
matouskozak wants to merge 5 commits into
Open
Conversation
Preserve the dotnet/dotnet VMR commit separately and resolve the corresponding dotnet/runtime commit from the VMR source manifest. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f1a9ef3e-205a-409a-9aec-5ca6a2dbe255
Run only Android CoreCLR Release on the Pixel configuration for the private sanity build. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f1a9ef3e-205a-409a-9aec-5ca6a2dbe255
Remove the temporary single-configuration validation override after queuing the targeted build. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f1a9ef3e-205a-409a-9aec-5ca6a2dbe255
Contributor
There was a problem hiding this comment.
Pull request overview
Updates SDK measurement metadata to preserve the VMR commit and report the corresponding dotnet/runtime commit.
Changes:
- Resolves the runtime commit from
source-manifest.json. - Records both VMR and runtime commit hashes.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Treat runtime commit resolution as best-effort so transient network or malformed manifest failures do not prevent versions.json from being written. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f1a9ef3e-205a-409a-9aec-5ca6a2dbe255
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
src/scenarios/shared/versionmanager.py:10
URLErroris imported here but never referenced; the resolver catchesExceptioninstead. Please remove this dead import (otherwise F401-based Python linting will fail).
from urllib.error import URLError
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PERFLAB_DATA_dotnet_commit_hashsrc/source-manifest.jsonPERFLAB_DATA_runtime_commit_hashValidation
Private Android CoreCLR Release sanity build succeeded: build 3055756.