Skip to content

[ci-fix] Needs review: mark Apple runner interop as safe (refs #134061) - #134186

Draft
github-actions[bot] wants to merge 1 commit into
mainfrom
ci-fix/134061-apple-runner-safety-134061-e9da55cdf242d383
Draft

github-actions[bot] wants to merge 1 commit into
mainfrom
ci-fix/134061-apple-runner-safety-134061-e9da55cdf242d383

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Workflow artifact: ci-fix
Artifact kind: help
Linked KBE: #134061

Note

This is an AI/Copilot-generated best-effort fix attempt that I could not fully validate. It is a starting point for a maintainer, not a finished change. Please review the analysis below before merging.

Root cause (best analysis)

Apple NativeAOT test legs fail to compile AppleTestRunner.cs: the source-generated LibraryImport declarations for mono_ios_append_output and mono_ios_set_summary trigger SYSLIB1064 because they lack an explicit memory-safety context.

Attempted fix

Marks both P/Invoke declarations safe. They marshal managed strings and expose no pointer parameters, so this preserves the runner’s existing interop behavior while satisfying the compiler’s required explicit context.

What is unverified / where I need help

  • The required libraries baseline build could not be started because the execution environment rejected ./build.sh clr+libs -rc release before execution.
  • Please confirm this compiler-version-specific safe annotation is accepted across the Apple NativeAOT target matrix.

Validation

  • Command: ./build.sh clr+libs -rc release
  • Result: not run because the execution environment rejected the command before it started

Evidence

  • Failing build: 1596986
  • First build it occurred: 1596986 — 2026-09-15 UTC
  • Suspected regressing change: none identified with sufficient confidence

Help wanted

  • Area owners (area-Infrastructure-libraries): @dotnet/area-infrastructure-libraries

Filed by ci-failure-fix. Comment here or on the workflow file to suggest changes; ci-failure-scan-feedback reads in-scope feedback daily and opens (or updates) a PR with prompt edits.

Structured data:

{
  "artifact_kind": "help",
  "linked_kbe": 134061,
  "workflow_artifact": "ci-fix"
}

Generated by CI Outer-Loop Failure Fixer · gpt56 · 124.3 AIC · ⌖ 18.2 AIC · ⊞ 26.9K ·

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants