Conversation
Move unsafe contexts from type declarations to the pointer operations and mark native imports with explicit unsafe contracts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e8bb4900-bf72-4876-b479-091185e5b89a
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The template currently declares pointer types/members in non-unsafe types, which should not compile as written.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
This PR updates the Android NativeAOT app template used by AndroidAppBuilder to accommodate the “updated memory safety rules” by moving unsafe contexts closer to the pointer operations and adding explicit unsafe contracts on native imports.
Changes:
- Localizes
unsafeusage to specific blocks around pointer operations in the template entrypoints. - Adds explicit
unsafemodifiers to native import declarations (e.g.,LibraryImport,DllImport) that use pointer types. - Adjusts JNI helper types to remove type-level
unsafe(but the current diff leaves pointer members in non-unsafetypes, which needs correction).
| File | Description |
|---|---|
| src/tasks/AndroidAppBuilder/Templates/monodroid-nativeaot.cs | Refactors unsafe usage and interop declarations in the Android NativeAOT template to comply with updated memory-safety requirements. |
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Android NativeAOT build failure in the runtime-extra-platforms pipeline after System.Text.Json source-generation tests enabled
updated-memory-safety-rules.The Android test template relied on type-level
unsafecontexts, which have no effect under the updated rules. Move the contexts to the pointer operations and add explicit unsafe contracts to the native imports. The template remains compatible with the legacy rules.Validation:
./build.sh tasksSINGLE_FILE_TEST_RUNNERpath with updated memory safety rulesNote
This PR description was generated with GitHub Copilot.