[release/11.0] Fix not-greater-than predicate when lowering SIMD selects - #134214
Open
github-actions[bot] wants to merge 1 commit into
Open
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
EgorBo
approved these changes
Sep 18, 2026
Member
|
Approved. Please check test failures once CI is done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #133589 to release/11.0
/cc @tannergooding
Customer Impact
This fixes #133550, where AVX-512 lowering changes
CompareNotGreaterThantoCompareGreaterThanwhen folding a comparison into a masked SIMD select. Applications can silently receive the opposite selected value for less-than, equal, greater-than, and unordered inputs. The repro fails on .NET 11 RC2 but behaves correctly on .NET 8, 9, and 10.Regression
The incorrect predicate mapping was introduced during the .NET 11 development cycle; the exact introducing change was not identified.
Testing
The source PR added focused 128- and 256-bit
floatanddoubleregressions covering less-than, equal, greater-than, and NaN inputs. All 10 cases failed before the fix on AVX-512 and passed afterward. They also passed with AVX-512 and AVX2 disabled, with the applicable 128-bit cases passing with AVX disabled. Existing packed and scalar AVX comparison tests passed, and disassembly confirmed only the intended predicate changed without increasing instruction count or code size.Risk
Low. The product change corrects a single intrinsic mapping from
CompareGreaterThanMasktoCompareNotGreaterThanMask. Focused coverage exercises all relevant predicates, element types, vector widths, NaN handling, and non-AVX-512 fallbacks.IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.release/X.0(no-stagingsuffix).Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.
Note
This backport template was completed by GitHub Copilot at the user's direction.