Remove JsonToItemsTaskFactory - #134221
Draft
rainersigwald wants to merge 3 commits into
Draft
rainersigwald wants to merge 3 commits into
rainersigwald wants to merge 3 commits into
Conversation
Keep JsonToItemsTaskFactory behavior unchanged while moving parsing and item conversion into reusable helpers. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Register the fixed-shape readers directly and remove the custom task factory unsupported by multithreaded MSBuild. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Cover output compatibility, invalid manifests, and legacy and multithreaded MSBuild hosting. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The replacement preserves the scoped outputs and includes focused coverage for both legacy and multithreaded MSBuild execution.
Pull request overview
Replaces the unsupported custom JSON task factory with fixed compiled MSBuild tasks for WASM and Mono component manifests.
Changes:
- Adds shared JSON parsing and explicit task outputs.
- Updates WASM/mobile registrations to use compiled tasks.
- Adds legacy and multithreaded MSBuild coverage.
File summaries
| File | Description |
|---|---|
src/tasks/MonoTargetsTasks/JsonToItemsTaskFactory/README.md |
Removes obsolete factory documentation. |
src/tasks/MonoTargetsTasks/JsonToItemsTaskFactory/JsonToItemsTaskFactory.cs |
Removes the custom task factory. |
src/tasks/MonoTargetsTasks/JsonToItems/README.md |
Documents the replacement tasks. |
src/tasks/MonoTargetsTasks/JsonToItems/JsonToItemsTasks.cs |
Defines fixed compiled tasks. |
src/tasks/MonoTargetsTasks/JsonToItems/JsonToItemsReader.cs |
Implements shared manifest parsing. |
src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csproj |
References the task project. |
src/mono/wasm/Wasm.Build.Tests/JsonManifestReaderTests.cs |
Tests parsing and MSBuild modes. |
src/mono/wasm/build/WasmApp.Common.targets |
Registers the compiled WASM task. |
src/mono/nuget/Microsoft.NET.Runtime.MonoTargets.Sdk/Sdk/MonoTargetsTasks.props |
Registers the compiled component task. |
src/mono/nuget/Microsoft.NET.Runtime.MonoTargets.Sdk/README.md |
Documents component-manifest support. |
src/mono/msbuild/common/CommonMobileBuild.props |
Updates mobile task registration. |
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 0
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running in multithreaded mode, MSBuild does not support custom task factories.
JsonToItemsTaskFactoryis used for two scoped cases that can be replaced by small tasks with explicit inputs, so I've done so here.