Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15157 +/- ##
=============================================
Coverage 37.24166% 37.24166%
=============================================
Files 246 246
Lines 9774 9774
Branches 1029 1029
=============================================
Hits 3640 3640
Misses 5970 5970
Partials 164 164
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@sanskarIN please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Placement bounds are inconsistent, root menu placement is not addressed, and regression coverage is missing.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
This pull request improves horizontal ContextMenuStrip submenu placement near monitor boundaries.
Changes:
- Preserves parent-item collision handling.
- Selects the horizontal direction with more visible space.
- Leaves vertical dropdown behavior unchanged.
| File | Summary |
|---|---|
src/System.Windows.Forms/System/Windows/Forms/Controls/ToolStrips/ToolStripDropDownItem.cs |
Adds monitor-aware horizontal submenu direction selection. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| // Keep a horizontal submenu on the same monitor as its parent item. | ||
| if (dropDownDirection is ToolStripDropDownDirection.Left or ToolStripDropDownDirection.Right) | ||
| { | ||
| Rectangle workingArea = Screen.FromRectangle(ownerItemBounds).WorkingArea; |
| if (alternateVisibleArea > currentVisibleArea) | ||
| { | ||
| dropDownDirection = alternateDirection; | ||
| } |


Summary
Fixes #11289.
ContextMenuStripsubmenus can open on the adjacent monitor when the parent menu is close to a monitor boundary, particularly in multi-monitor configurations with different DPI settings.This change updates
ToolStripDropDownItem.DropDownDirectionso horizontal submenus compare their available space on the monitor containing the parent item and choose the direction that provides more visible area on that monitor.Changes
Validation
Tested the affected behavior with a multi-monitor Windows configuration matching the conditions reported in #11289.
Verified:
Related issue
Fixes #11289.
Microsoft Reviewers: Open in CodeFlow