[Tony-ST0754]

fix:getScrollElement方法中由找 parentNode 变更为找 parentElement，以防特殊情况 document 没有 scrollTo 方法导致第29行执行错误

Link issues

fixes #8646

解决方案 / Solution

const getScrollElement = el => {
    let ele = el
    while (ele && ele.scrollHeight <= ele.clientHeight + 1) {
        // ele.parentNode 会继续找到 document，导致后续调用不存在的 document.scrollTo() 方法报错
        // 所以这里改为 parentElement，parentElement 到 html 就会返回 null，正确回退到 window
        ele = ele.parentElement
    }
    return ele || window
}

Summary By Copilot

Regression?

• Yes
• No

Risk

• High
• Medium
• Low

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No
• N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

• Doc is updated/provided or not needed
• Demo is updated/provided or not needed
• Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

• Prevent GoTop scroll handling from traversing to the document and calling an unavailable scroll method in edge cases.

[bb-auto]

Thanks for your PR, @Tony-ST0754. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates GoTop’s scroll-element lookup to traverse DOM elements only, avoiding an invalid document.scrollTo() call and correctly falling back to window.

Flow diagram for GoTop scroll-element lookup

flowchart TD
    A[Start with GoTop element] --> B{Element can scroll?}
    B -->|Yes| C[Return scroll element]
    B -->|No| D[Move to parentElement]
    D --> E{Parent element exists?}
    E -->|Yes| B
    E -->|No| F[Return window]

Loading

File-Level Changes

Change	Details	Files
Prevent scroll-target traversal from reaching the document node, ensuring the GoTop fallback uses window when no scrollable ancestor exists.	Replace parentNode traversal with parentElement traversal. Rely on parentElement returning null at the html boundary so getScrollElement falls back to window. Add inline comments documenting the document.scrollTo failure scenario and fallback behavior. Remove the file’s leading BOM during the import-line update.	src/BootstrapBlazor/Components/GoTop/GoTop.razor.js

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#8646	Ensure the GoTop button does not throw when the page has no scrollable content, by falling back to window instead of attempting to call scrollTo() on document.	✅

Possibly linked issues

• bug(GoTop): ele.parentNode 会继续找到 document，导致后续调用不存在的 document.scrollTo() 方法报错 #8646: The PR changes the exact traversal causing the issue, allowing lookup to fall back to window instead of document.
• bug(GoTop): ele.parentNode 会继续找到 document，导致后续调用不存在的 document.scrollTo() 方法报错 #8646: The PR updates GoTop’s scroll-element lookup, matching the issue’s request to update its scroll-check logic.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (1806aab) to head (45f3262).

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #8647   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          776       776           
  Lines        35234     35234           
=========================================
  Hits         35234     35234           

Flag	Coverage Δ
BB	100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.