Skip to content

Fix frontend dependency advisories and enforce high-severity audit (#500) - #502

Merged
dovvnloading merged 7 commits into
mainfrom
fix/frontend-npm-advisories-500
Nov 14, 2026
Merged

dovvnloading merged 7 commits into
mainfrom
fix/frontend-npm-advisories-500

Conversation

@dovvnloading

Copy link
Copy Markdown
Owner

Security remediation — closes #500

An authenticated npm audit of the original pinned 406-package frontend tree found 14 advisories: 2 high (Vite and Zod) and 12 moderate (including Vitest mocker, minimatch, ESLint/TypeScript linting). The automated npm audit fix --dry-run and npm 10's ordinary lockfile regeneration crashed in Arborist (Cannot read properties of null (reading 'edgesOut')), so we reviewed the direct fixes and generated the lockfile with npm 11 rather than force-upgrading.

Intentional changes

  • Bump Vite to ^8.3.8, Vitest and coverage to ^4.1.12, ESLint to ^10.15.0, and TypeScript ESLint to ^8.72.2.
  • Override inherited minimatch to patched 11.0.8 (a major dependency override needed because upstream tools still request ^10) and inherited zod to patched ^4.6.7.
  • Commit the regenerated npm lockfile, and add a permanent high/critical npm audit gate to the pull-request Quality workflow.

Verification already performed

The temporary, branch-scoped GitHub Actions repair run #43612040362 installed from the regenerated lockfile and passed npm audit (0 total vulnerabilities), npm audit --omit=dev, npm run typecheck, npm run lint, all 1,231 frontend tests under coverage, and the production frontend build. The temporary write-capable repair workflow has been deleted from this PR.

Release requirements

Run the full Windows Quality matrix, including real-browser Playwright tests, backend contracts, dependency review, and packaged-app smoke test, before merging. The minimatch major override is deliberately covered by the lint and TypeScript ESLint test suite. Do not claim all future vulnerabilities are resolved: audit is a point-in-time assessment.

Closes #500.

@dovvnloading dovvnloading left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final QA: reviewed the three-file diff and verified the temporary write-capable remediation workflow is not included. Registry audit of the original dependency graph identified 14 advisories (2 high, 12 moderate). Regenerated the npm lockfile using reviewed direct upgrades and scoped minimatch/zod overrides; npm 10's automatic resolver was crashing. A real npm installation from the new lockfile reports 0 vulnerabilities on both the entire tree and production-only tree, and the temporary runner passed all 1,231 frontend unit tests, typecheck, lint, and bundle build. Windows Quality run #985 (43612416911) passes all 12 jobs, including all backend shards/coverage, 43 Chromium tests, Windows package/smoke, dependency-review, and new high-severity npm audit gate. The minimatch 11 override is a transitive major replacement, validated against the entire lint/unit/browser toolchain. No unresolved review issues found. Author QA comment, not an independent approval.

@dovvnloading
dovvnloading merged commit 770386a into main Nov 14, 2026
16 checks passed
@dovvnloading
dovvnloading deleted the fix/frontend-npm-advisories-500 branch November 14, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Triage existing frontend npm audit advisories (2 high, 12 moderate)

1 participant