Repository navigation
Scientific Workbench: Fitting and Inference pack (NIST-validated) - #588
Merged
Merged
Conversation
dovvnloading
marked this pull request as ready for review
November 18, 2026 13:42
dovvnloading
commented
Nov 18, 2026
dovvnloading
left a comment
Owner
Author
There was a problem hiding this comment.
Adversarial numerical review completed.
- Verified the changes are restricted to the seven permitted paths; no existing tests, chart/UI code, workflows, or packaging configuration were modified.
- Reproduced NIST StRD Longley to all 15 published significant digits (coefficients and uncertainties), and Misra1a, Thurber, MGH09 to all 11 published digits including uncertainties and RSS from both NIST starts. Checked analytic Jacobians against independent finite differences.
- Checked singular/underdetermined design matrices, zero-weight rows, invalid model domains, non-finite input, numerical underflow, beta/gamma domain validation, and the receipt integrity contract. Corrected central Student-t CDF cancellation before committing; tested tail values against published distribution tables and independently compared large randomized samples to SciPy/NumPy (not runtime dependencies).
- Re-ran focused tests (42 passed); CI passes Windows full pytest with coverage, Ruff, mypy, perf, POSIX permissions, wheel build/install, and frontend checks. E2E is intentionally skipped for PRs by existing workflow configuration.
- Read back each changed file from GitHub after its push and verified the exact Git blob SHA; no readback mismatches.
- Intervals are correctly characterized as local linearized/Wald intervals, and expected-count restrictions/LM convergence limits are documented rather than overstating inference certainty.
No unresolved review threads or scope violations. Final review outcome: ready for merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fitting and Inference pack
Adds a separately enableable
plugins/science_fittingmanifest andgraphlink_plugins/scientific/packs/fitting.py, registered through the existing catalog and Scientific Workbench contract.Algorithms and outputs
docs/SCIENTIFIC_FITTING_REFERENCE.mdcovers equations, assumptions, singularity/non-convergence handling, statistical limitations, table provenance, and reproduction.Reference evidence
Change control
Only seven permitted paths changed. No existing tests, web UI, chart files, build files, or workflows were modified. Four small commits; pushed blobs verified by GitHub readback SHA after every push.