Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KafkaProducer.send(...).get(timeout=0)can currently returnNonewhile the record is still pending. A positive timeout can do the same if a batch-split wakeup reaches the deadline before the next loop iteration. An unfinished future should raiseKafkaTimeoutError, not appear to have returned a delivery result.Move the deadline check inside the wait loop so completed success/error results still win, while unfinished calls raise when the budget expires. Add MockBroker regressions for pending sends, eventual success/failure after a timeout, and a controlled rebind at the deadline.
Local validation on macOS / Python 3.13.12:
git diff --check.No real broker, full repository suite, other Python versions, or hosted CI was run locally. AI assistance was used to investigate, implement, review, and test this change.