Skip to content

fix(e2e): poll the live tool count instead of reading it once #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codyllord merged 1 commit into from
Sep 22, 2026
Merged

fix(e2e): poll the live tool count instead of reading it once #530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions e2e/mcp-service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,16 @@ function headerToolsLiveChip(page: Page): Locator {
return page.locator('.mcp-head').getByRole('button', { name: /tools live/ });
}

/**
* The header chip's current number, or null while it has not rendered one.
* Deliberately assertion-free so it can drive expect.poll.
*/
async function toolsLiveCount(page: Page): Promise<number | null> {
const text = (await headerToolsLiveChip(page).textContent()) ?? '';
const m = text.match(/(\d+) tools live/);
return m ? parseInt(m[1], 10) : null;
}

async function numberFrom(locator: Locator, re: RegExp): Promise<number> {
const text = (await locator.textContent()) ?? '';
const m = text.match(re);
Expand Down Expand Up @@ -135,10 +145,14 @@ test.describe('MCP editor — Connect tab', () => {
{ timeout: 15_000 }
);

// Header carries the live effective count, N > 0 and = model(config).
const n = await numberFrom(headerToolsLiveChip(page), /(\d+) tools live/);
expect(n).toBeGreaterThan(0);
expect(n).toBe(expectedTotal());
// Header carries the live effective count, = model(config). The chip paints
// as soon as the editor does, before the backend-services fetch lands, so it
// starts at the services-less count and settles once the catalog arrives.
// Read it with a retrying assertion rather than once.
expect(expectedTotal()).toBeGreaterThan(0);
await expect
.poll(() => toolsLiveCount(page), { timeout: 15_000 })
.toBe(expectedTotal());
});

test('client panels are auth-aware and never leak a real credential', async ({
Expand Down
Loading