Skip to content

Add local pre-signed URL placeholders#568

Draft
srinivasBJ wants to merge 2 commits into
drivendataorg:masterfrom
srinivasBJ:fix-local-presigned-url
Draft

Add local pre-signed URL placeholders#568
srinivasBJ wants to merge 2 commits into
drivendataorg:masterfrom
srinivasBJ:fix-local-presigned-url

Conversation

@srinivasBJ

@srinivasBJ srinivasBJ commented Jun 12, 2026

Copy link
Copy Markdown

Summary

  • return a clearly marked placeholder URL when local cloud paths are presigned
  • preserve the requested expiry in the placeholder query parameters
  • cover Azure, Google Cloud Storage, and S3 local implementations
  • document that local placeholder URLs cannot access files

Closes #525

Testing

  • make lint
  • .venv/bin/python -m pytest -q
  • 1019 passed, 5 skipped

Contributor checklist

  • I have read and understood CONTRIBUTING.md
  • Confirmed an issue exists for the PR, and the text Closes #issue appears in the PR summary
  • Confirmed PR is based on the latest master
  • Confirmed failure before change and success after change
  • Any generic new functionality is replicated across cloud providers if necessary
  • Tested manually against live server backend for at least one provider
  • Added tests for the new functionality
  • Linting passes locally
  • Tests pass locally
  • Updated HISTORY.md with the issue and PR addressed

@srinivasBJ srinivasBJ force-pushed the fix-local-presigned-url branch from 695605a to 66e6186 Compare June 12, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Local testing of pre-signed URLs

1 participant