Skip to content

Delegate AWS endpoint environment handling#569

Draft
srinivasBJ wants to merge 1 commit into
drivendataorg:masterfrom
srinivasBJ:codex/remove-custom-aws-endpoint-env
Draft

Delegate AWS endpoint environment handling#569
srinivasBJ wants to merge 1 commit into
drivendataorg:masterfrom
srinivasBJ:codex/remove-custom-aws-endpoint-env

Conversation

@srinivasBJ

Copy link
Copy Markdown

Summary

  • remove cloudpathlib's custom AWS_ENDPOINT_URL lookup
  • delegate endpoint environment variable handling to boto3/botocore
  • verify an explicit endpoint_url still takes precedence

Closes #194

Testing

  • make lint
  • .venv/bin/python -m pytest -q
  • 1016 passed, 5 skipped

Contributor checklist

  • I have read and understood CONTRIBUTING.md
  • Confirmed an issue exists for the PR, and the text Closes #issue appears in the PR summary
  • Confirmed PR is based on the latest master
  • Confirmed failure before change and success after change
  • Any generic new functionality is replicated across cloud providers if necessary
  • Tested manually against live server backend for at least one provider
  • Added tests for the updated behavior
  • Linting passes locally
  • Tests pass locally
  • Updated HISTORY.md with the issue addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove setting endpoint_url from env variable AWS_ENDPOINT_URL

1 participant