Add --dry-run flag to restore#344
Merged
Merged
Conversation
Preview the intended restore without calling the Dropbox API: text output prints "Would restore <path> to revision <rev>" and JSON reports status "planned" with dry_run=true in the result input. Extract plannedMetadata() into dry_run.go to synthesize a jsonMetadata from a path/kind, and route mkdir's planned result through it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
--dry-runflag todbxcli restore, matching the convention already used bymkdir,rm,mv, andcp.Would restore <path> to revision <rev>without calling the Dropbox API.plannedwithdry_run=truein the result input.Also extracts a small
plannedMetadata(kind, path)helper intodry_run.gothat synthesizes ajsonMetadatafrom a path/kind, and routesmkdir's planned result through it to remove duplicated literal construction.