Add --dry-run flag to put#345
Merged
Merged
Conversation
Preview intended uploads without calling the Dropbox API across all put paths: single file, recursive directory, and stdin. Text output prints "Would upload <src> to <dst>" (and "Would create directory <dst>" for folders); JSON reports status "planned" with dry_run=true in the input. plannedPutRecursiveResults mirrors putRecursiveInternal's two-pass local walk (files then empty dirs, preserving the skipped-symlink warning) but plans results instead of issuing writes. Single-file dry-run still reads destination metadata so the resolved target path matches a real upload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
--dry-runflag todbxcli put, matching the convention used bymkdir,rm,restore,mv, andcp. Covers all three upload paths:Would upload <src> to <dst>; resolves the destination path (reading dest metadata) so the previewed target matches a real upload.Would upload - to <dst>without reading stdin.JSON output reports status
plannedwithdry_run=truein the input. Manifest, JSON contract test, and golden schema updated in lockstep; regenerated docs/schemas show no drift.plannedPutRecursiveResultsmirrorsputRecursiveInternal's two-pass walk (a comment ties their traversal semantics together) but plans results instead of issuing writes.