Repository navigation
build: pin Maven 3.9.16 with the Maven Wrapper - #1567
Merged
Merged
Conversation
GitHub's Ubuntu runner image moved to Maven 3.10.0, whose resolver rejects '/' in artifact classifiers. Tycho 5.0.4 injects the nested jars of bundles such as org.apache.ant as system dependencies classified by their Bundle-ClassPath entry (lib/ant-antlr.jar), so every build now fails in xtext.expression with "Invalid Collect Request" (eclipse-tycho/tycho#6399). Build through a Maven Wrapper pinned to 3.9.16, with the distribution's SHA-256, in CI and in the documented commands, and cap the enforced Maven version below 3.10 so that a 3.10 build fails early with a pointer to ./mvnw. Remove the cap and bump the wrapper once Tycho supports 3.10. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
joaodinissf
marked this pull request as ready for review
October 9, 2026 09:55
rubenporras
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why the change
Every build is red since GitHub's Ubuntu runner image moved from Maven 3.9.16 to 3.10.0. Maven 3.10's resolver rejects
/in artifact classifiers, and Tycho 5.0.4 injects the nested jars of bundles such asorg.apache.antas dependencies classified by theirBundle-ClassPathentry (lib/ant-antlr.jar). The build stops inxtext.expressionwith "Invalid Collect Request" (eclipse-tycho/tycho#6399, open, no fix released yet).Special things to note
./mvnw. The wrapper is the script-only type, so no jar is committed; it downloads Maven from Maven Central and checks it against the pinned SHA-256 (checked against Central's published SHA-512).[3.9.0,3.10)) with a message pointing to./mvnw, instead of the resolver error further in.distributionUrlanddistributionSha256Sumand widen the enforcer range again../mvnwthe full build with all static checks (tests skipped) passes; a tampered checksum is rejected.Change outline
+mvnw, mvnw.cmd, .mvn/wrapper/maven-wrapper.properties (Maven 3.9.16, SHA-256 pinned) .github/workflows/verify.yml, snapshot.yml mvn → ./mvnw ddk-parent/pom.xml enforcer [3.9.0,4) → [3.9.0,3.10), with message AGENTS.md build commands use ./mvnw🤖 Generated with Claude Code