Repository navigation
Report batch failures with BatchUpdateException and update counts - #903
Merged
staticlibs merged 1 commit intoOct 9, 2026
Conversation
Signed-off-by: hutiefang76 <137664623+hutiefang76@users.noreply.github.com>
staticlibs
approved these changes
Oct 9, 2026
staticlibs
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR! Looks good to me.
staticlibs
pushed a commit
that referenced
this pull request
Oct 10, 2026
This is a backport of the PR #903 to `v2.0-cyanoptera` branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a command in a batch fails, both Statement and PreparedStatement currently rethrow a plain SQLException. Callers that catch BatchUpdateException cannot inspect which commands executed before the failure.
Wrap the error in BatchUpdateException with the executed prefix of update counts and preserve its SQLState, vendor code and cause. Use the long[] constructor for both executeBatch and executeLargeBatch, keeping the existing stop-at-first-failure and transaction behavior.
The regression tests fail against the original implementation. After the change, TestBatch (17 tests) and TestPrepare (28 tests) pass with the locally built native driver on macOS arm64/JDK 17:
make testreaches an unrelated failure intest_scalar_function_vectorized_parallel_streams(a result unexpectedly becomes NULL). That test also fails in three isolated runs with the original PreparedStatement implementation. I am investigating that separately; this PR does not claim the full suite passes. The modified Java files pass clang-format.AI assistance was used for implementation and review.