Repository navigation
Reject JDBC factories on closed connections - #905
Merged
staticlibs merged 1 commit intoOct 9, 2026
Merged
staticlibs merged 1 commit into
staticlibs merged 1 commit into
Conversation
Signed-off-by: hutiefang76 <137664623+hutiefang76@users.noreply.github.com>
staticlibs
approved these changes
Oct 9, 2026
staticlibs
left a comment
staticlibs
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR! Looks good to me.
staticlibs
pushed a commit
that referenced
this pull request
Oct 10, 2026
This is a backport of the PR #905 to `v2.0-cyanoptera` branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getMetaData(),createArrayOf()andcreateStruct()currently return objects after their connection is closed, although the JDBC contract requires a SQLException. Reuse the existing connection guard in all three supported factory methods so callers receive the driver's usual08003error.Separate regression tests cover each closed-connection method and preserve successful calls on an open connection. All three closed cases failed against the original class. The revised TestClosure suite passed all 36 tests; the original validation also passed the array/struct neighboring tests (40 and 21 runs respectively).
Validation compiled the changed Java classes and tests, then ran the official test runner with those classes ahead of an existing JNI build on the classpath. No native rebuild or complete project suite was run for this Java-only change. The final review used JDK 21; the additions use Java 8 APIs.
AI assistance: DeepSeek assisted implementation and initial review; the final diff and actual regression output were checked before submission.