Conversation
Regression Report: PR #9599Models tested: 1 Scope note: CI relations were built with the current bounded window
Verification queries:
Downstream diffs, briefly: |
PR SummaryMedium Risk Overview The old monthly Reviewed by Cursor Bugbot for commit c01b3b5. Configure here. |
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit c01b3b5. Configure here.
0xRobin
left a comment
There was a problem hiding this comment.
@tomfutago this tightly couples the runs of the latest_state to the event_deltas model which is not ideal.
If they are ever out of sync they will start producing wrong data..
I'm not sure this is the right approach.
Summary
This PR refactors Sui object-event anchoring so
tokens_sui_object_event_deltasno longer reconstructs prior object state by scanning recent history directly. Instead, it introducestokens_sui_coin_object_latest_stateas a compact helper table with one latest pre-window Coin object state perobject_id, and uses that helper to stitch incremental windows safely. The downstream transfer models keep the same output contract, while the anchor reconstruction work moves into a reusable state layer.Expected Performance
Structural reasoning, pending the first production-shaped CI/prod run:
tokens_sui_object_event_deltasno longer scans recent month-to-date history to reconstruct anchors.tokens_sui_coin_object_latest_state, joined to the active window’swindow_first_versionobject set.recent_history_anchorsscan is eliminated fromobject_event_deltas.window_first_versiongroup-by runs over the already-loaded active window rows, so it should be small relative to the removed history scan.Rough estimate:
25m, a more realistic first expectation is “meaningfully below that,” roughly in the5-15mrange depending on merge overhead